Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in rms_calculation are incorrect #790

Closed
matteobachetti opened this issue Jan 18, 2024 · 0 comments · Fixed by #792
Closed

Errors in rms_calculation are incorrect #790

matteobachetti opened this issue Jan 18, 2024 · 0 comments · Fixed by #792

Comments

@matteobachetti
Copy link
Member

matteobachetti commented Jan 18, 2024

When simulating many times a PDS with a given rms and measuring it with our rms_calculation in fourier.py, the error bars are underestimated (red lines indicate the calculated error, the blue ones the actual standard deviation of the measurements in the thousands of realization)
image

I re-implemented the method from scratch, using clearer passages to normalize the spectrum correctly, and I obtain something like this:
image

So, there must be an error somewhere. Since the current code is rather clunky, I'm inclined to deprecate the old function and create a new one with clearer parameters (e.g. making it clear whether a parameter refers to the full observation or each segment of the averaged spectrum, like nphots_per_segment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant