Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okx.com (Opinionated?) #1945

Closed
merganon opened this issue Apr 12, 2022 · 10 comments
Closed

okx.com (Opinionated?) #1945

merganon opened this issue Apr 12, 2022 · 10 comments
Labels
upstream The issue is upstream

Comments

@merganon
Copy link

merganon commented Apr 12, 2022

Hey Steven,

I saw that okx.com was added to the unified hosts list, however I don't see any issue or pull request where OKX was suggested to be added. It seems like it was added manually.

OKX is a cryptocurrency exchange. What's the reason to have it in the list?

Note: I am not affiliated with OKX. I just care about non-opinionated filter lists.

Thank you for your work by the way!

@welcome
Copy link

welcome bot commented Apr 12, 2022

Hello! Thank you for opening your first issue in this repo. It’s people like you who make these host files better!

@StevenBlack
Copy link
Owner

Hello @merganon thank you for this.

The domain okx.com comes to us from upstream, via the KADhosts list.

Can you submit this to their Issues page? https://github.com/PolishFiltersTeam/KADhosts/issues

Ping @krystian3w can you assess the inclusion of domain okx.com?

@StevenBlack StevenBlack added the upstream The issue is upstream label Apr 12, 2022
@krystian3w
Copy link

krystian3w commented Apr 12, 2022

In Poland can by dangerous use:

https://forexrev.pl/ostrzezenia-4-04-fincloud-cryptobull-nexfx/

Website no support pl. subdomain or tld (public suffix) to unlock international version.

But http://cnmv.es/Portal/ResultadoBusqueda.aspx?tipo=1&lang=en&page=0 deleted opinion about risk.

@StevenBlack
Copy link
Owner

Thank you @krystian3w.

Whatever you decide is fine with me.

Closing.

@merganon
Copy link
Author

This sounds like a Poland-only issue. @StevenBlack 's hosts are used by people worldwide.

It looks like KADhosts is focused on Polish users - why is this included in the unified hosts list? I suggest we branch out to different countries/languages, just like EasyList has filters for different countries.

@StevenBlack
Copy link
Owner

@merganon I beg your pardon?

What an insulting, arrogant comment.

Yeah @merganon, you do that. Fill your boots. Now go away.

@merganon
Copy link
Author

I think you misunderstood me.

There is a reason why EasyList has decided to create different filters for German, Spanish, Chinese, Slovenian, etc. people. because it could create false positives, just how it happens with okx.com at the moment.

@StevenBlack
Copy link
Owner

@merganon I can tell you with confidence: my list is not for you.

I trust you understand that.

Now please, go away, or I will block you.

@merganon merganon changed the title okx.com okx.com (Opinionated?) Apr 13, 2022
@merganon
Copy link
Author

Yes, I understand you now. I just had a glance and it seems like KADhosts is heavily opinionated, they are blocking lots of crypto-related pages. Leaving it here so others know to avoid using your hosts if you are calling KADhosts "reputable".

image

FiltersHeroes/KADhosts#14

@StevenBlack
Copy link
Owner

Sorry for all this @krystian3w. I have blocked this repugnant asshole.

I know that nobody works harder than you guys. Nobody is more diligent and reliable than the maintainers of KADhosts. Not just recently, but consistently, over many, many years.

@krystian3w I asked you for comment, and you replied promptly, with documentation. You are a ⭐ and I apologize for all of this. You deserve better. Thank you for all you guys do.

I am locking this issue now.

Repository owner locked as resolved and limited conversation to collaborators Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream The issue is upstream
Projects
None yet
Development

No branches or pull requests

3 participants