-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't display a dialog after popover did close (iOS only) #40
Comments
I ran into this issue as well recently, for a quick fix you can pass in I agree this is an issue and I may be able to fix this by tying into the Modal |
onDismiss works nice, why not just pass a callback for it and this should wrap this up |
already done, just need to do some testing and documentation |
Ok, just released version 2.0.0, the prop is now |
@SteffeyDev awesome. Did you know that onDismiss prop in Modal is iOS-only though? |
I was not aware, let me add a platform check in there... |
Ok fixed (hopefully). v. 2.0.1 |
Describe the bug
In
popoverDoneClosing
I want to open the Alert dialog. On iOS, the alert closes straight after it showed and after that the app freezes. You can't tap anything, my guess is that popover modal doesn't close properly and overlays the entire screen (like in #16). If you wrap Alert in setTimeout with 0 (zero) interval you may get this behavior after the second hit. You can try it out in this Expo Snack: https://snack.expo.io/HJFjG-G9V With 100 interval, it's pretty much ok, but it still freezes occasionally.Expected bevavior: I call Alert in popoverDoneClosing and it displays without closing and freezing the app, without the need to set a timeout.
Device/Setup Info:
react-native
version: 0.58.5react-native-popover-view
version: 1.0.19Debug Output
This bug does not reproduce when Remote Debug is enabled.
The text was updated successfully, but these errors were encountered: