Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More granular control to animations #166

Open
araujobarret opened this issue Aug 4, 2023 · 7 comments
Open

More granular control to animations #166

araujobarret opened this issue Aug 4, 2023 · 7 comments

Comments

@araujobarret
Copy link

Is your feature request related to a problem? Please describe.
I want to be able to customize not only the animation duration, delay, etc, but the types of animations happening.

Describe the solution you'd like
Or to pass some props to toggle which animations we use from the existing ones(with initial value also controlled via prop) or to pass custom animations and these could overwrite all animations happening in the component.

From these 2 ideas, I guess the easiest one is the first, if you think it's valid I can try submitting a PR next week but would like to hear from you if you approve, which solution is a quick win, etc.

@SteffeyDev
Copy link
Owner

Do you mean that you want, for example, the open animation to have a different animationConfig than the close animation?

@araujobarret
Copy link
Author

araujobarret commented Aug 4, 2023

Not animationConfig, I mean fade, scale and translate, in our case we loved the lib, simplified our popover but we bumped into the locked animations, for example only wanting to use fade 0 -> 1 and scale .9 -> 1

Not only in the animateOut but also animateIn in this case.
ref

@SteffeyDev
Copy link
Owner

Got it, that makes sense. I'm not sure the best approach, but feel free to propose a PR with whatever method you find simplest and I will review.

@araujobarret
Copy link
Author

Cool! Will work on it next week 👍

@AdamGerthel
Copy link
Contributor

@araujobarret did you come up with anything?

@araujobarret
Copy link
Author

Actually not, had to speed up other things and gave up on it 😓

@AdamGerthel
Copy link
Contributor

It looks pretty straightforward. I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants