Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point should be exported from the package #154

Open
luixo opened this issue Jan 25, 2023 · 0 comments
Open

Point should be exported from the package #154

luixo opened this issue Jan 25, 2023 · 0 comments

Comments

@luixo
Copy link

luixo commented Jan 25, 2023

Describe the bug
I have a thin wrapper around Popover that adds <Touchable /> for children that don't have it by default. For that I need to check from prop on being a Rect / Point / function etc.

// getFrom function
if ( ... ||
  props.from instanceof Rect ||
  props.from instanceof Point
) {
  return props.from;
}
return <Touchable>{props.from}</Touchable>

But to check from on being Point I need that class exported from the package and it is currently not. I have to import it manually from one of the files: import { Point } from "react-native-popover-view/dist/Types";
I believe it should be reexported in react-native-popover-view/dist/index.d.ts file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant