From 31bdac6e7072694642e56e673c4771713758969e Mon Sep 17 00:00:00 2001 From: Leonard Thieu Date: Mon, 8 Jan 2018 13:20:39 -0500 Subject: [PATCH 1/3] fix: Ensure code coverage results are generated. OpenCover requires Windows PDBs. In addition, the -oldStyle switch must be passed for .NET Standard projects. --- SteamKit2/SteamKit2/SteamKit2.csproj | 5 +++++ appveyor.yml | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/SteamKit2/SteamKit2/SteamKit2.csproj b/SteamKit2/SteamKit2/SteamKit2.csproj index 520d70cfe..305ceedab 100644 --- a/SteamKit2/SteamKit2/SteamKit2.csproj +++ b/SteamKit2/SteamKit2/SteamKit2.csproj @@ -16,6 +16,11 @@ bin\$(Configuration)\$(TargetFramework)\SteamKit2.xml + + + full + true + diff --git a/appveyor.yml b/appveyor.yml index b83b7a93b..739f1f688 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -54,7 +54,7 @@ test_script: if ($env:CONFIGURATION -eq 'Debug') { & nuget install OpenCover -Version 4.6.519 -OutputDirectory SteamKit2\packages - & SteamKit2\packages\OpenCover.4.6.519\tools\OpenCover.Console.exe -register:user "-target:%ProgramFiles%\dotnet\dotnet.exe" "-targetargs:test SteamKit2\Tests\Tests.csproj" -returntargetcode "-filter:+[SteamKit2]* -[SteamKit2]SteamKit2.Internal.* -[SteamKit2]SteamKit2.*.Internal.* -[SteamKit2]SevenZip*" "-excludebyattribute:*.ProtoContract*" -hideskipped:All -output:SteamKit2-code-coverage.xml + & SteamKit2\packages\OpenCover.4.6.519\tools\OpenCover.Console.exe -register:user "-target:%ProgramFiles%\dotnet\dotnet.exe" "-targetargs:test SteamKit2\Tests\Tests.csproj" -returntargetcode "-filter:+[SteamKit2]* -[SteamKit2]SteamKit2.Internal.* -[SteamKit2]SteamKit2.*.Internal.* -[SteamKit2]SevenZip*" "-excludebyattribute:*.ProtoContract*" -hideskipped:All -output:SteamKit2-code-coverage.xml -oldStyle $env:Path = "C:\Python34;C:\Python34\Scripts;" + $env:Path & pip install codecov & codecov -f "SteamKit2-code-coverage.xml" -X gcov From 19497aa451908fb1b3228ea98273904a3aa6d6c6 Mon Sep 17 00:00:00 2001 From: Leonard Thieu Date: Mon, 8 Jan 2018 13:32:23 -0500 Subject: [PATCH 2/3] fix(build): Fix build failing due to being unable to locate Codecov executable. --- appveyor.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 739f1f688..92eddaae8 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -55,9 +55,8 @@ test_script: { & nuget install OpenCover -Version 4.6.519 -OutputDirectory SteamKit2\packages & SteamKit2\packages\OpenCover.4.6.519\tools\OpenCover.Console.exe -register:user "-target:%ProgramFiles%\dotnet\dotnet.exe" "-targetargs:test SteamKit2\Tests\Tests.csproj" -returntargetcode "-filter:+[SteamKit2]* -[SteamKit2]SteamKit2.Internal.* -[SteamKit2]SteamKit2.*.Internal.* -[SteamKit2]SevenZip*" "-excludebyattribute:*.ProtoContract*" -hideskipped:All -output:SteamKit2-code-coverage.xml -oldStyle - $env:Path = "C:\Python34;C:\Python34\Scripts;" + $env:Path - & pip install codecov - & codecov -f "SteamKit2-code-coverage.xml" -X gcov + & nuget install Codecov -Version 1.0.3 -OutputDirectory SteamKit2\packages + & SteamKit2\packages\Codecov.1.0.3\tools\codecov.exe -f "SteamKit2-code-coverage.xml" } artifacts: From 17edfbe8a9eaf378d90afd5effc489531028229a Mon Sep 17 00:00:00 2001 From: Leonard Thieu Date: Mon, 8 Jan 2018 22:44:29 -0500 Subject: [PATCH 3/3] Generate symbols independent of platform. --- SteamKit2/SteamKit2/SteamKit2.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SteamKit2/SteamKit2/SteamKit2.csproj b/SteamKit2/SteamKit2/SteamKit2.csproj index 305ceedab..4c805a3e5 100644 --- a/SteamKit2/SteamKit2/SteamKit2.csproj +++ b/SteamKit2/SteamKit2/SteamKit2.csproj @@ -17,7 +17,7 @@ bin\$(Configuration)\$(TargetFramework)\SteamKit2.xml - + full true