Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DebugLog with Microsoft.Extensions.Logging #636

Open
yaakov-h opened this issue Feb 5, 2019 · 0 comments
Open

Replace DebugLog with Microsoft.Extensions.Logging #636

yaakov-h opened this issue Feb 5, 2019 · 0 comments

Comments

@yaakov-h
Copy link
Member

yaakov-h commented Feb 5, 2019

Since there's now a fairly standard .NET method of logging - or at least a standard set of interfaces for multiple backends, we don't really need our own.

If we can, only take a dependency on Microsoft.Extensions.Logging.Abstractions and let the consumer deal with setup and implementation, if they even care to enable logging.

Our samples (3.DebugLog) should provide a reasonable default, probably AddConsole().

Try not to take a dependency on MS DI if we don't need to.

See also: dotnet/extensions#615 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant