Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMClient.Send should throw when trying to send without a connection #1101

Open
xPaw opened this issue May 19, 2022 · 1 comment
Open

CMClient.Send should throw when trying to send without a connection #1101

xPaw opened this issue May 19, 2022 · 1 comment
Labels

Comments

@xPaw
Copy link
Member

xPaw commented May 19, 2022

What did you expect to happen?

Right now Send() just silently eats the send by doing a null check on connection, and catches io and socket exceptions.

Instead of that, what actually happened?

I think it should throw so any requests are not lost into ether (and I think async jobs will not resolve/fail until the next disconnect).

Which operating system are you running on?

No response

Which .NET Runtime are you running on?

.NET Core or .NET 5 or higher.

Version

6

Relevant log output

No response

Example Code

No response

Additional Information

No response

@xPaw xPaw added the bug label May 19, 2022
@azuisleet
Copy link
Member

Additional diagnostics available in #1102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants