feat(hypixel-api): create hypixel api client #409
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jacobk999
requested changes
Aug 28, 2022
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "name": "@statsify/hypixel-api-client", | |||
| } | ||
| } | ||
|
|
||
| export type HypixelAPIConfig = { |
There was a problem hiding this comment.
Suggested change
| export type HypixelAPIConfig = { | |
| export interface HypixelAPIConfig { |
| return this.get("status", { uuid }); | ||
| } | ||
|
|
||
| public guild(params: { id?: string; player?: string; name?: string }) { |
There was a problem hiding this comment.
Make a type called GuildParams
type GuildParams = { id: string } | { uuid: string } | { name: string }
Suggested change
| public guild(params: { id?: string; player?: string; name?: string }) { | |
| public guild(params: GuildParams) { |
| this.config = config; | ||
| } | ||
|
|
||
| public player(uuid: string): Promise<HypixelPlayer | undefined> { |
| return response.data; | ||
| } catch (error: any) { | ||
| switch (error.code) { | ||
| case 429: { |
There was a problem hiding this comment.
This could also be player name searched too recently and it could lead to an endless loop
eatmyvenom
force-pushed
the
feat/hypixel-api
branch
from
37129e0 to
01c8702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo