Delete phone numbers from inventory and Twilio #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agreenspan24
previously approved these changes
Nov 6, 2020
| style: inlineStyles.column, | ||
| render: (columnKey, row) => | ||
| this.props.params.ownerPerms ? ( | ||
| <FlatButton |
There was a problem hiding this comment.
Why not an IconButton?
There was a problem hiding this comment.
I initially tried IconButton but it didn't look right to me. No hover state and the tool tip was getting cut off by the row, which I'm sure is fixable but FlatButton seemed fine.
| @@ -264,6 +309,29 @@ class AdminPhoneNumberInventory extends React.Component { | |||
| > | |||
| {this.renderBuyNumbersForm()} | |||
| </Dialog> | |||
| <Dialog | |||
| title="Delete Numbers" | |||
| modal={false} | |||
There was a problem hiding this comment.
I believe false is the default here.
schuyler1d
reviewed
Nov 10, 2020
src/server/api/lib/twilio.js
Outdated
| */ | ||
| async function deleteNumber(twilioInstance, phoneSid, phoneNumber) { | ||
| const response = await twilioInstance.incomingPhoneNumbers(phoneSid).remove(); | ||
| if (response.error) { |
There was a problem hiding this comment.
I think my one request here is that instead of throwing if deleting a number fails, we should just count/track the errors here. A use case that came up for us and at least one other campaign was deleting numbers in Spoke when at least some of them were already deleted from the Twilio console.
Other than that, looks good.
schuyler1d
added
the
S-waiting on author
jeffm2001
removed
the
S-waiting on author
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds delete buttons to the phone number inventory page, which lets you bulk remove unallocated numbers for an area code from both the Spoke inventory and you Twilio account.
Checklist: