Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Add All" button on Texters admin page #795

Closed
suegibson opened this issue Aug 20, 2018 · 11 comments · Fixed by #2063
Closed

Remove "Add All" button on Texters admin page #795

suegibson opened this issue Aug 20, 2018 · 11 comments · Fixed by #2063
Labels
A-Admin UI/UX Area: Admin experience of using Spoke C-design Type: anything under the umbrella of visual, interface, or experience design good first issue O-wfp-priority Organization: Priority for the Working Families Party

Comments

@suegibson
Copy link

Does anyone have use for the Add All button when making texting assignments? Because we don’t in #text4resistance, and it’s just annoying when all users get assigned without consent.
@codygordon @lperson

@schuyler1d schuyler1d added the O-wfp-priority Organization: Priority for the Working Families Party label Jun 18, 2019
@ibrand ibrand added A-Admin UI/UX Area: Admin experience of using Spoke C-design Type: anything under the umbrella of visual, interface, or experience design labels Jan 23, 2020
@ibrand
Copy link
Collaborator

ibrand commented May 16, 2020

@deasterdaywfp @jeffm2001 @schuyler1d do any of you use the "Add All" button? If so, I'll close this. Otherwise maybe we should deprecate it

@suegibson
Copy link
Author

We do not use it at WFP and would like for it to be gone. @ibrand

@jeffm2001
Copy link
Collaborator

I'm fine with removing it

@deasterdaywfp
Copy link
Collaborator

deasterdaywfp commented May 18, 2020 via email

@ibrand
Copy link
Collaborator

ibrand commented May 19, 2020

Let's remove the Add All button! This is ready for someone to take on

@schuyler1d
Copy link
Collaborator

going to claim this as part of work in https://github.com/MoveOnOrg/Spoke/issues/1533

@ibrand ibrand added the S-in progress Status: Issue label for once a contributor has picked it up. Especially meant for Good First Issues. label May 20, 2020
@schuyler1d schuyler1d changed the title Add All button on Texters admin page Remove "Add All" button on Texters admin page May 20, 2020
@ryanjcrump
Copy link
Collaborator

I hope we're still getting rid of this!!

@Frydafly
Copy link
Collaborator

checking in on the status of this since https://github.com/MoveOnOrg/Spoke/issues/1533 was closed?

@schuyler1d schuyler1d added good first issue and removed S-in progress Status: Issue label for once a contributor has picked it up. Especially meant for Good First Issues. labels Mar 15, 2021
@schuyler1d
Copy link
Collaborator

this still needs to be done. This would be a very easy PR removing these lines:
https://github.com/MoveOnOrg/Spoke/blob/main/src/components/CampaignTextersForm.jsx#L475-L481

@schuyler1d schuyler1d removed their assignment Mar 15, 2021
Frydafly referenced this issue Mar 19, 2021
Fixes https://github.com/MoveOnOrg/Spoke/issues/795 which suggests removing "Add All" button on Texter Admin Page
@Frydafly Frydafly linked a pull request Mar 19, 2021 that will close this issue
7 tasks
@ryanjcrump
Copy link
Collaborator

Is this done? I'm still seeing Add All after all these years :)

@crayolakat
Copy link
Collaborator

It will be closed in Spoke release 12 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Admin UI/UX Area: Admin experience of using Spoke C-design Type: anything under the umbrella of visual, interface, or experience design good first issue O-wfp-priority Organization: Priority for the Working Families Party
Projects
None yet
8 participants