Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Dynamic assignment should allow a blank MAX_CONTACTS_PER_TEXTER variable but does not #1349

Closed
ibrand opened this issue Jan 6, 2020 · 3 comments
Labels
A-server-side (nodejs) Area: All changes on the server side A-text assignment Area: Text assignment bugs, features, and proposals C-bug Type: Bug S-needs confirmation Status: Need to check if this is still an issue and can be reproduced

Comments

@ibrand
Copy link
Collaborator

ibrand commented Jan 6, 2020

Describe the bug
The intended usage of the env var MAX_CONTACTS_PER_TEXTER was to allow texters to choose as many texts as they'd like if the var was left blank. Instead leaving the var blank makes dynamic assign no longer an option.

To Reproduce
Steps to reproduce the behavior:

  1. Set MAX_CONTACTS_PER_TEXTER either to nothing or to 0
  2. See that dynamic assignment is no longer available

Expected behavior
We expect that if MAX_CONTACTS_PER_TEXTER is blank, a texter can text as many texts as they'd like and if MAX_CONTACTS_PER_TEXTER is 0, dynamic assign is off.

Additional context
This was first surfaced in #1066 and so the context of that discovery process is there.

@ibrand ibrand added the C-bug Type: Bug label Jan 6, 2020
@ibrand ibrand added A-text assignment Area: Text assignment bugs, features, and proposals A-server-side (nodejs) Area: All changes on the server side labels Jan 27, 2020
@ibrand ibrand added the S-needs confirmation Status: Need to check if this is still an issue and can be reproduced label May 18, 2020
@ibrand
Copy link
Collaborator Author

ibrand commented May 18, 2020

RFC #1533 would impact dynamic assign in a way where this might not be an issue anymore, but that's unclear

@schuyler1d
Copy link
Collaborator

schuyler1d commented Mar 15, 2021

I believe this is resolved, but we should confirm. Note -- setting max contacts for a specific assignment to 0 should stop that texter from texting. Setting MAX_CONTACTS env var to 0 doesn't make sense -- that would block all texters from texting. Setting it to blank means there is no maximum.

@schuyler1d
Copy link
Collaborator

Realizing this shouldn't be an issue after the rewrite -- max contacts relates to dynamic assignment very differently now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-server-side (nodejs) Area: All changes on the server side A-text assignment Area: Text assignment bugs, features, and proposals C-bug Type: Bug S-needs confirmation Status: Need to check if this is still an issue and can be reproduced
Projects
None yet
Development

No branches or pull requests

2 participants