[Enhancement] adjust meta_sync_force_delete_shard_meta logic #53933
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: starrocks-xupeng <[email protected]>
starrocks-xupeng
force-pushed
the
sync
branch
from
f5189d9 to
096b934
Compare
kevincai
reviewed
Dec 13, 2024
| try { | ||
| if (!shardIds.isEmpty()) { | ||
| Set<Long> shards = new HashSet<Long>(shardIds); | ||
| starOSAgent.deleteShards(shards); |
There was a problem hiding this comment.
is it possible to log the shard storage path, so the reminder data on remote storage path can be collected from logfile and do some post-action offline later.
|
murphyatwork
approved these changes
Dec 13, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: