Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix log block not record disks requested from the DirManager #53925

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[BugFix] Fix log block not record disks requested from the DirManager #53925

merged 1 commit into from
Dec 13, 2024
+48 −22

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Dec 13, 2024 •
edited
Loading

Why I'm doing:

the request bytes allocate from dir manager will never release. it will cause always no writeable spill dirs.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@stdpain stdpain requested a review from a team as a code owner December 13, 2024 06:54
@stdpain stdpain mentioned this pull request Dec 13, 2024
Open
24 tasks
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 13 / 13 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/spill/file_block_manager.cpp 7 7 100.00% []
🔵 be/src/exec/spill/log_block_manager.cpp 6 6 100.00% []

@stdpain stdpain merged commit 601f2ad into StarRocks:main Dec 13, 2024
54 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 13, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Dec 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@stdpain @mergify
[BugFix] Fix log block not record disks requested from the DirManager (…
fd9a95e 
…#53925)

Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 601f2ad)
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@stdpain @mergify
[BugFix] Fix log block not record disks requested from the DirManager (…
7badc90 
…#53925)

Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 601f2ad)
This was referenced Dec 13, 2024
Merged
Open
wanpengfei-git pushed a commit that referenced this pull request Dec 13, 2024
@mergify @stdpain
[BugFix] Fix log block not record disks requested from the DirManager…
4ea312a 
… (backport #53925) (#53942)

Co-authored-by: stdpain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seaven Seaven Seaven approved these changes

@silverbullet233 silverbullet233 silverbullet233 approved these changes

Assignees

@stdpain stdpain

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stdpain @silverbullet233 @Seaven