-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support inet_aton function #51883
Conversation
@Seaven @wangsimo0 Can you help review this PR? Thank you! |
CI: Run echo "::error::Please check the format of your pr body about the behavior change checkbox!" |
@stdpain Thank you for your feedback! I will address these suggestions as soon as possible. |
Quality Gate passedIssues Measures |
namespace starrocks { static inline bool try_parse_ipv4(const char* pos, int64& result_value) { DEFINE_UNARY_FN_WITH_IMPL(convert_to_ipv4_impl, str) { StatusOr StringFunctions::inet_aton(FunctionContext* context, const Columns& columns) {
} } // namespace starrocks |
Signed-off-by: lufeizxy <[email protected]>
Signed-off-by: lufeizxy <[email protected]>
Signed-off-by: lufeizxy <[email protected]>
b3f8bb1
to
6841ff7
Compare
Signed-off-by: lufeizxy <[email protected]>
6841ff7
to
485a8c8
Compare
CI failed in your cases:
|
@stdpain I will resolve it as soon as possible. |
Signed-off-by: lufeizxy <[email protected]>
Signed-off-by: lufeizxy <[email protected]>
@stdpain I have resolved the CI failures in my cases. Could you please review the PR again? Thank you! |
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 37 / 43 (86.05%) file detail
|
Why I'm doing:
What I'm doing:
Support inet_aton function
For #49664
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: