Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]implement dayofweek in FE (backport #51453) #51803

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 11, 2024

Why I'm doing:

If the where condition contains a partition condition that is compared with the dayofweek function, a full table scan will be required, and FE is required to implement the dayofweek function to perform partition pruning when generating the execution plan.

What I'm doing:

implement dayofweek in FE
Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

FE支持DAYOFWEEK 函数
实现前:
image
image

实现后:
image
image

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51453 done by [Mergify](https://mergify.com). ## Why I'm doing: If the where condition contains a partition condition that is compared with the dayofweek function, a full table scan will be required, and FE is required to implement the dayofweek function to perform partition pruning when generating the execution plan. ## What I'm doing: implement dayofweek in FE Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

FE支持DAYOFWEEK 函数
实现前:
image
image

实现后:
image
image

@mergify mergify bot added the conflicts label Oct 11, 2024
Copy link
Contributor Author

mergify bot commented Oct 11, 2024

Cherry-pick of fb41039 has failed:

On branch mergify/bp/branch-3.0/pr-51453
Your branch is up to date with 'origin/branch-3.0'.

You are currently cherry-picking commit fb41039314.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctionsTest.java

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Oct 11, 2024
24 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 11, 2024 11:09
@mergify mergify bot closed this Oct 11, 2024
auto-merge was automatically disabled October 11, 2024 11:14

Pull request was closed

Copy link
Contributor Author

mergify bot commented Oct 11, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@Seaven Seaven reopened this Oct 12, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 12, 2024 07:37
Signed-off-by: evenhuang <[email protected]>
(cherry picked from commit fb41039)

Signed-off-by: even986025158 <[email protected]>
@Seaven Seaven force-pushed the mergify/bp/branch-3.0/pr-51453 branch from 579f635 to ac13211 Compare October 12, 2024 07:51
Copy link

sonarcloud bot commented Oct 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@wanpengfei-git wanpengfei-git merged commit fec263e into branch-3.0 Oct 12, 2024
30 of 32 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.0/pr-51453 branch October 12, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants