Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]implement dayofweek in FE #51453

Merged

Conversation

even986025158
Copy link
Contributor

@even986025158 even986025158 commented Sep 26, 2024

Why I'm doing:

If the where condition contains a partition condition that is compared with the dayofweek function, a full table scan will be required, and FE is required to implement the dayofweek function to perform partition pruning when generating the execution plan.

What I'm doing:

implement dayofweek in FE
Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

FE支持DAYOFWEEK 函数
实现前:
image
image

实现后:
image
image

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

// function of dayofweek in starrocks monday is 2 and sunday is 1, so need mod 7 and plus 1.
return ConstantOperator.createInt((date.getDatetime().getDayOfWeek().getValue()) % 7 + 1);
}

@ConstantFunction.List(list = {
@ConstantFunction(name = "years_add", argTypes = {DATETIME,
INT}, returnType = DATETIME, isMonotonic = true),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most risky bug in this code is:
Using date.getDatetime().getDayOfWeek() on an integer type could cause a runtime exception.

You can modify the code like this:

@ConstantFunction.List(list = {
        @ConstantFunction(name = "dayofweek", argTypes = {DATETIME}, returnType = INT),
        @ConstantFunction(name = "dayofweek", argTypes = {DATE}, returnType = INT)
})
public static ConstantOperator dayofweek(ConstantOperator date) {
    // LocalDateTime.getDayOfWeek is return day of the week, such as monday is 1 and sunday is 7.
    // function of dayofweek in starrocks monday is 2 and sunday is 1, so need mod 7 and plus 1.
    return ConstantOperator.createInt((date.getDatetime().getDayOfWeek().getValue()) % 7 + 1);
}

// Remove this entry as it handles integers which are not suitable for getDayOfWeek
@Deprecated
@ConstantFunction(name = "dayofweek", argTypes = {INT}, returnType = INT)

@trueeyu
Copy link
Contributor

trueeyu commented Oct 9, 2024

@Mergifyio rebase main

Copy link
Contributor

mergify bot commented Oct 9, 2024

rebase main

✅ Branch has been successfully rebased

@trueeyu trueeyu force-pushed the community/dayofweek_implement_fe branch from 9c2635f to fe7b23b Compare October 9, 2024 01:58
@even986025158 even986025158 force-pushed the community/dayofweek_implement_fe branch from fe7b23b to 17cf5ab Compare October 9, 2024 07:49
@trueeyu
Copy link
Contributor

trueeyu commented Oct 11, 2024

https://github.com/Mergifyio rebase main

Copy link
Contributor

mergify bot commented Oct 11, 2024

rebase main

✅ Branch has been successfully rebased

@trueeyu trueeyu force-pushed the community/dayofweek_implement_fe branch from 17cf5ab to 6467f82 Compare October 11, 2024 06:40
Copy link

sonarcloud bot commented Oct 11, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@trueeyu trueeyu merged commit fb41039 into StarRocks:main Oct 11, 2024
44 checks passed
Copy link

@Mergifyio backport branch-3.3

Copy link

@Mergifyio backport branch-3.2

Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Oct 11, 2024
Copy link
Contributor

mergify bot commented Oct 11, 2024

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Oct 11, 2024

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 11, 2024
Signed-off-by: evenhuang <[email protected]>
(cherry picked from commit fb41039)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java
#	fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctionsTest.java
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
Signed-off-by: evenhuang <[email protected]>
(cherry picked from commit fb41039)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java
#	fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctionsTest.java
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
Signed-off-by: evenhuang <[email protected]>
(cherry picked from commit fb41039)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java
#	fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctionsTest.java
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
Signed-off-by: evenhuang <[email protected]>
(cherry picked from commit fb41039)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java
#	fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctionsTest.java
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
Signed-off-by: evenhuang <[email protected]>
(cherry picked from commit fb41039)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java
#	fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctionsTest.java
Seaven pushed a commit that referenced this pull request Oct 12, 2024
Signed-off-by: evenhuang <[email protected]>
(cherry picked from commit fb41039)

Signed-off-by: even986025158 <[email protected]>
Seaven pushed a commit that referenced this pull request Oct 12, 2024
Signed-off-by: evenhuang <[email protected]>
(cherry picked from commit fb41039)

Signed-off-by: even986025158 <[email protected]>
Seaven pushed a commit that referenced this pull request Oct 12, 2024
Signed-off-by: evenhuang <[email protected]>
(cherry picked from commit fb41039)

Signed-off-by: even986025158 <[email protected]>
Seaven pushed a commit that referenced this pull request Oct 12, 2024
Signed-off-by: evenhuang <[email protected]>
(cherry picked from commit fb41039)

Signed-off-by: even986025158 <[email protected]>
Seaven pushed a commit that referenced this pull request Oct 12, 2024
Signed-off-by: evenhuang <[email protected]>
(cherry picked from commit fb41039)

Signed-off-by: even986025158 <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 12, 2024
wanpengfei-git pushed a commit that referenced this pull request Oct 12, 2024
wanpengfei-git pushed a commit that referenced this pull request Oct 12, 2024
Seaven pushed a commit that referenced this pull request Oct 12, 2024
Signed-off-by: evenhuang <[email protected]>
(cherry picked from commit fb41039)

Signed-off-by: even986025158 <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 12, 2024
wanpengfei-git pushed a commit that referenced this pull request Oct 12, 2024
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants