Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Operator's statistics not be estimated during JoinReorder of table-pruning phase #51304

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[BugFix] Operator's statistics not be estimated during JoinReorder of table-pruning phase #51304

merged 1 commit into from
Sep 24, 2024

Conversation

satanson
Copy link
Contributor

Why I'm doing:

https://starrocks.atlassian.net/browse/SR-30556

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@satanson satanson requested a review from a team as a code owner September 24, 2024 05:29
@satanson
Copy link
Contributor Author

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 24, 2024

rebase

✅ Branch has been successfully rebased

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/join/ReorderJoinRule.java 7 7 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@satanson satanson enabled auto-merge (squash) September 24, 2024 09:17
@satanson satanson merged commit 61ebfc7 into main Sep 24, 2024
42 checks passed
@satanson satanson deleted the prune_table_npe branch September 24, 2024 09:18
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 24, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 3.0 label Sep 24, 2024
@github-actions github-actions bot removed the 2.5 label Sep 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 24, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 24, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 24, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 24, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 24, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 24, 2024
@satanson @mergify
[BugFix] Operator's statistics not be estimated during JoinReorder of…
d3e879a 
… table-pruning phase (#51304)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 61ebfc7)
mergify bot pushed a commit that referenced this pull request Sep 24, 2024
@satanson @mergify
[BugFix] Operator's statistics not be estimated during JoinReorder of…
c7c2ef2 
… table-pruning phase (#51304)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 61ebfc7)
This was referenced Sep 24, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Sep 24, 2024
@satanson @mergify
[BugFix] Operator's statistics not be estimated during JoinReorder of…
caef3e7 
… table-pruning phase (#51304)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 61ebfc7)
@mergify mergify bot mentioned this pull request Sep 24, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Sep 24, 2024
@satanson @mergify
[BugFix] Operator's statistics not be estimated during JoinReorder of…
b68f597 
… table-pruning phase (#51304)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 61ebfc7)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
mergify bot pushed a commit that referenced this pull request Sep 24, 2024
@satanson @mergify
[BugFix] Operator's statistics not be estimated during JoinReorder of…
ef07755 
… table-pruning phase (#51304)

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 61ebfc7)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
This was referenced Sep 24, 2024
Closed
Closed
wanpengfei-git pushed a commit that referenced this pull request Sep 24, 2024
@mergify @satanson
[BugFix] Operator's statistics not be estimated during JoinReorder of…
6e45d72 
… table-pruning phase (backport #51304) (#51323)

Co-authored-by: satanson <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Sep 24, 2024
@mergify @satanson
[BugFix] Operator's statistics not be estimated during JoinReorder of…
447192c 
… table-pruning phase (backport #51304) (#51324)

Co-authored-by: satanson <[email protected]>
kangkaisen pushed a commit that referenced this pull request Sep 24, 2024
@mergify @satanson
[BugFix] Operator's statistics not be estimated during JoinReorder of…
41a8961 
… table-pruning phase (backport #51304) (#51325)

Co-authored-by: satanson <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@satanson @renzhimin7
[BugFix] Operator's statistics not be estimated during JoinReorder of…
efe6fb1 
… table-pruning phase (StarRocks#51304)

Signed-off-by: satanson <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murphyatwork murphyatwork murphyatwork approved these changes

@Seaven Seaven Seaven approved these changes

@LiShuMing LiShuMing LiShuMing approved these changes

Assignees

@satanson satanson

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@satanson @LiShuMing @Seaven @murphyatwork