Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix an issue When connection failed, CloseListener was not executed. (backport #46164) #46265

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 26, 2024

Why I'm doing:

When MysqlProto. SendResponsePacket executed failed, CloseListener is not registered, then connectionMap unable to remove the connection

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #46164 done by [Mergify](https://mergify.com). ## Why I'm doing: When MysqlProto. SendResponsePacket executed failed, CloseListener is not registered, then connectionMap unable to remove the connection ## What I'm doing: Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…xecuted. (#46164)

Why I'm doing:
When MysqlProto. SendResponsePacket executed failed, CloseListener is not registered, then connectionMap unable to remove the connection

Signed-off-by: edwinhzhang <[email protected]>
(cherry picked from commit 25ae3ad)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/mysql/nio/AcceptListener.java
Copy link
Contributor Author

mergify bot commented May 26, 2024

Cherry-pick of 25ae3ad has failed:

On branch mergify/bp/branch-2.5/pr-46164
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 25ae3ad80e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/mysql/nio/AcceptListener.java

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label May 26, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) May 26, 2024 13:36
@mergify mergify bot closed this May 26, 2024
auto-merge was automatically disabled May 26, 2024 13:36

Pull request was closed

Copy link
Contributor Author

mergify bot commented May 26, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-46164 branch May 26, 2024 13:36
@nshangyiming nshangyiming restored the mergify/bp/branch-2.5/pr-46164 branch June 11, 2024 07:18
@nshangyiming nshangyiming reopened this Jun 11, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 11, 2024 07:19
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@wanpengfei-git wanpengfei-git merged commit 810e9fd into branch-2.5 Jun 11, 2024
30 of 32 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-2.5/pr-46164 branch June 11, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants