[Enhancement] Optimize LoadsHistorySyncer #53864
Open
+78
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengjun-git
changed the title
gengjun-git
changed the title
meegoo
reviewed
Dec 12, 2024
| LOG.warn("failed to get db: {}, table: {}", LOADS_HISTORY_DB_NAME, LOADS_HISTORY_TABLE_NAME); | ||
| return; | ||
| } | ||
| long latestFinishTime = GlobalStateMgr.getCurrentState().getLoadMgr() |
There was a problem hiding this comment.
also need to check StreamLoadMgr
nshangyiming
previously approved these changes
Dec 12, 2024
[FE Incremental Coverage Report]✅ pass : 40 / 41 (97.56%) file detail
|
meegoo
reviewed
Dec 13, 2024
| if (syncedLoadFinishTime < latestFinishTime) { | ||
| syncData(); | ||
| // refer to SQL:LOADS_HISTORY_SYNC. Only sync loads that completed more than 1 minute ago | ||
| long oneMinAgo = System.currentTimeMillis() - 60000; |
meegoo
approved these changes
Dec 13, 2024
|
@Mergifyio rebase |
Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: gengjun-git <[email protected]>
✅ Branch has been successfully rebased |
gengjun-git
force-pushed
the
opt_load_history_sync
branch
from
37c1158 to
2b6267e
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: