[Enhancement] Add histogram metric and node info metric in json metric #53735

xiangran0327 · 2024-12-10T01:57:54Z

Why I'm doing:

The interface fe_ip:fe_port/metrics?type=json lacks the node metric and the histogram metric.

What I'm doing:

Add the node metric and the histogram metric in the interface fe_ip:fe_port/metrics?type=json

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Signed-off-by: xiangran0327 <[email protected]>

sonarqubecloud · 2024-12-13T02:34:52Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2024-12-13T06:19:24Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-12-13T06:20:03Z

[FE Incremental Coverage Report]

✅ pass : 39 / 39 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/metric/JsonMetricVisitor.java	39	39	100.00%	[]

github-actions · 2024-12-13T06:20:20Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-12-13T06:42:52Z

@Mergifyio backport branch-3.4

github-actions · 2024-12-13T06:42:53Z

@Mergifyio backport branch-3.3

github-actions · 2024-12-13T06:42:55Z

@Mergifyio backport branch-3.2

github-actions · 2024-12-13T06:42:56Z

@Mergifyio backport branch-3.1

mergify · 2024-12-13T06:42:59Z

backport branch-3.4

✅ Backports have been created

#53917 [Enhancement] Add histogram metric and node info metric in json metric (backport #53735) has been created for branch branch-3.4

mergify · 2024-12-13T06:43:01Z

backport branch-3.3

✅ Backports have been created

#53918 [Enhancement] Add histogram metric and node info metric in json metric (backport #53735) has been created for branch branch-3.3

mergify · 2024-12-13T06:43:02Z

backport branch-3.2

✅ Backports have been created

#53919 [Enhancement] Add histogram metric and node info metric in json metric (backport #53735) has been created for branch branch-3.2 but encountered conflicts

mergify · 2024-12-13T06:43:05Z

backport branch-3.1

✅ Backports have been created

#53920 [Enhancement] Add histogram metric and node info metric in json metric (backport #53735) has been created for branch branch-3.1 but encountered conflicts

#53735) Signed-off-by: xiangran0327 <[email protected]> (cherry picked from commit 1e402d6)

#53735) Signed-off-by: xiangran0327 <[email protected]> (cherry picked from commit 1e402d6) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/metric/JsonMetricVisitor.java

…c (backport #53735) (#53917) Co-authored-by: xiangran0327 <[email protected]>

…c (backport #53735) (#53918) Co-authored-by: xiangran0327 <[email protected]>

…c (backport #53735) (#53919) Signed-off-by: andyziye <[email protected]> Co-authored-by: xiangran0327 <[email protected]> Co-authored-by: andyziye <[email protected]>

…c (backport #53735) (#53920) Signed-off-by: andyziye <[email protected]> Co-authored-by: xiangran0327 <[email protected]> Co-authored-by: andyziye <[email protected]>

xiangran0327 requested a review from a team as a code owner December 10, 2024 01:57

github-actions bot added 3.4 3.3 3.2 3.1 labels Dec 10, 2024

mergify bot assigned xiangran0327 Dec 10, 2024

gengjun-git previously approved these changes Dec 11, 2024

View reviewed changes

HangyuanLiu previously approved these changes Dec 11, 2024

View reviewed changes

[Enhancement] Add histogram metric and node info metric in json metric

4f499b1

Signed-off-by: xiangran0327 <[email protected]>

xiangran0327 dismissed stale reviews from HangyuanLiu and gengjun-git via 4f499b1 December 12, 2024 06:59

xiangran0327 force-pushed the main branch from 0f9d74b to 4f499b1 Compare December 12, 2024 06:59

xiangran0327 requested review from HangyuanLiu and gengjun-git December 12, 2024 07:10

gengjun-git approved these changes Dec 12, 2024

View reviewed changes

HangyuanLiu approved these changes Dec 13, 2024

View reviewed changes

andyziye merged commit 1e402d6 into StarRocks:main Dec 13, 2024
51 checks passed

github-actions bot removed 3.4 3.3 labels Dec 13, 2024

github-actions bot removed the 3.2 label Dec 13, 2024

github-actions bot removed the 3.1 label Dec 13, 2024

mergify bot pushed a commit that referenced this pull request Dec 13, 2024

[Enhancement] Add histogram metric and node info metric in json metric (

447def1

#53735) Signed-off-by: xiangran0327 <[email protected]> (cherry picked from commit 1e402d6)

mergify bot mentioned this pull request Dec 13, 2024

[Enhancement] Add histogram metric and node info metric in json metric (backport #53735) #53917

Merged

18 tasks

mergify bot pushed a commit that referenced this pull request Dec 13, 2024

[Enhancement] Add histogram metric and node info metric in json metric (

c49232b

#53735) Signed-off-by: xiangran0327 <[email protected]> (cherry picked from commit 1e402d6)

mergify bot mentioned this pull request Dec 13, 2024

[Enhancement] Add histogram metric and node info metric in json metric (backport #53735) #53918

Merged

18 tasks

mergify bot mentioned this pull request Dec 13, 2024

[Enhancement] Add histogram metric and node info metric in json metric (backport #53735) #53919

Merged

18 tasks

mergify bot mentioned this pull request Dec 13, 2024

[Enhancement] Add histogram metric and node info metric in json metric (backport #53735) #53920

Merged

18 tasks

wanpengfei-git pushed a commit that referenced this pull request Dec 16, 2024

[Enhancement] Add histogram metric and node info metric in json metri…

add7481

…c (backport #53735) (#53917) Co-authored-by: xiangran0327 <[email protected]>

wanpengfei-git pushed a commit that referenced this pull request Dec 16, 2024

[Enhancement] Add histogram metric and node info metric in json metri…

4eda311

…c (backport #53735) (#53918) Co-authored-by: xiangran0327 <[email protected]>

github-actions bot added the 3.4-merged label Dec 16, 2024

github-actions bot added 3.3-merged 3.2-merged labels Dec 16, 2024

github-actions bot added the 3.1-merged label Dec 16, 2024

LiShuMing mentioned this pull request Dec 26, 2024

[BugFix] Fix HistogramMetric output in json format #54361

Merged

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Add histogram metric and node info metric in json metric #53735

[Enhancement] Add histogram metric and node info metric in json metric #53735

xiangran0327 commented Dec 10, 2024 •

edited

Loading

sonarqubecloud bot commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

mergify bot commented Dec 13, 2024 •

edited

Loading

mergify bot commented Dec 13, 2024 •

edited

Loading

mergify bot commented Dec 13, 2024 •

edited

Loading

mergify bot commented Dec 13, 2024 •

edited

Loading

[Enhancement] Add histogram metric and node info metric in json metric #53735

[Enhancement] Add histogram metric and node info metric in json metric #53735

Conversation

xiangran0327 commented Dec 10, 2024 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarqubecloud bot commented Dec 13, 2024

Quality Gate passed

github-actions bot commented Dec 13, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Dec 13, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Dec 13, 2024

[BE Incremental Coverage Report]

github-actions bot commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

mergify bot commented Dec 13, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 13, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 13, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 13, 2024 • edited Loading

✅ Backports have been created

xiangran0327 commented Dec 10, 2024 •

edited

Loading

mergify bot commented Dec 13, 2024 •

edited

Loading

mergify bot commented Dec 13, 2024 •

edited

Loading

mergify bot commented Dec 13, 2024 •

edited

Loading

mergify bot commented Dec 13, 2024 •

edited

Loading