[BugFix] Fix Attempt to unlock lock, not locked by current locker in mv refresh #51884

LiShuMing · 2024-10-14T09:25:24Z

Why I'm doing:

Fix two bugs in using mv:

refresh mvs may occur some exceptions below:

2024-10-14 12:32:08.193+08:00 WARN (starrocks-taskrun-pool-5|107576) [TaskRunExecutor.lambda$executeTaskRun$0():65] failed to execute TaskRun.
com.starrocks.sql.common.DmlException: Refresh materialized view hitted_mv_dw_bbzdb_bas_servicetype failed after retrying 1 times(try-lock 0 times), error-msg : java.lang.IllegalMonitorStateException: Attempt to unlock lock, not locked by current locker
	at com.starrocks.common.util.concurrent.lock.MultiUserLock.release(MultiUserLock.java:182)
	at com.starrocks.common.util.concurrent.lock.LockManager.release(LockManager.java:275)
	at com.starrocks.common.util.concurrent.lock.Locker.release(Locker.java:106)
	at com.starrocks.common.util.concurrent.lock.Locker.unLockTablesWithIntensiveDbLock(Locker.java:417)
	at com.starrocks.common.util.concurrent.lock.Locker.tryLockTableWithIntensiveDbLock(Locker.java:521)
	at com.starrocks.common.util.concurrent.lock.Locker.tryLockTableWithIntensiveDbLock(Locker.java:504)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.checkMvToRefreshedPartitions(PartitionBasedMvRefreshProcessor.java:280)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.doRefreshMaterializedView(PartitionBasedMvRefreshProcessor.java:412)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.doRefreshMaterializedViewWithRetry(PartitionBasedMvRefreshProcessor.java:366)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.doMvRefresh(PartitionBasedMvRefreshProcessor.java:325)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.processTaskRun(PartitionBasedMvRefreshProcessor.java:199)
	at com.starrocks.scheduler.TaskRun.executeTaskRun(TaskRun.java:270)
	at com.starrocks.scheduler.TaskRunExecutor.lambda$executeTaskRun$0(TaskRunExecutor.java:58)
	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.doRefreshMaterializedViewWithRetry(PartitionBasedMvRefreshProcessor.java:387) ~[starrocks-fe.jar:?]
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.doMvRefresh(PartitionBasedMvRefreshProcessor.java:325) ~[starrocks-fe.jar:?]
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.processTaskRun(PartitionBasedMvRefreshProcessor.java:199) ~[starrocks-fe.jar:?]
	at com.starrocks.scheduler.TaskRun.executeTaskRun(TaskRun.java:270) ~[starrocks-fe.jar:?]
	at com.starrocks.scheduler.TaskRunExecutor.lambda$executeTaskRun$0(TaskRunExecutor.java:58) ~[starrocks-fe.jar:?]
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?]
	at java.lang.Thread.run(Thread.java:829) ~[?:?]
Caused by: java.lang.IllegalMonitorStateException: Attempt to unlock lock, not locked by current locker
	at com.starrocks.common.util.concurrent.lock.MultiUserLock.release(MultiUserLock.java:182) ~[starrocks-fe.jar:?]
	at com.starrocks.common.util.concurrent.lock.LockManager.release(LockManager.java:275) ~[starrocks-fe.jar:?]
	at com.starrocks.common.util.concurrent.lock.Locker.release(Locker.java:106) ~[starrocks-fe.jar:?]
	at com.starrocks.common.util.concurrent.lock.Locker.unLockTablesWithIntensiveDbLock(Locker.java:417) ~[starrocks-fe.jar:?]
	at com.starrocks.common.util.concurrent.lock.Locker.tryLockTableWithIntensiveDbLock(Locker.java:521) ~[starrocks-fe.jar:?]
	at com.starrocks.common.util.concurrent.lock.Locker.tryLockTableWithIntensiveDbLock(Locker.java:504) ~[starrocks-fe.jar:?]
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.checkMvToRefreshedPartitions(PartitionBasedMvRefreshProcessor.java:280) ~[starrocks-fe.jar:?]
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.doRefreshMaterializedView(PartitionBasedMvRefreshProcessor.java:412) ~[starrocks-fe.jar:?]
	at com.starrocks.scheduler.PartitionBasedMvRefreshProcessor.doRefreshMaterializedViewWithRetry(PartitionBasedMvRefreshProcessor.java:366) ~[starrocks-fe.jar:?]
	... 8 more

query will be rewritten wrong if contains col in (upper('a'), lower('a');

What I'm doing:

1. Unlock is not safe if batch locks fail, add try-catch to avoid this.
1. Using Maps.newTreeMap() instead of CASE_INSENSITIVE_ORDER to avoid this.

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

fe/fe-core/src/main/java/com/starrocks/sql/analyzer/PlannerMetaLocker.java

fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/Locker.java

murphyatwork · 2024-10-15T08:32:48Z

...-core/src/main/java/com/starrocks/sql/optimizer/rewrite/scalar/MvNormalizePredicateRule.java

@@ -70,7 +70,7 @@ public class MvNormalizePredicateRule extends NormalizePredicateRule {
    @Override
    public ScalarOperator visitCompoundPredicate(CompoundPredicateOperator predicate,
                                                 ScalarOperatorRewriteContext context) {
-        Map<String, ScalarOperator> sorted = Maps.newTreeMap(String.CASE_INSENSITIVE_ORDER);
+        Map<String, ScalarOperator> sorted = Maps.newTreeMap();


if changed, the column name would be case-sensitive, which means behavior change ?

add more comments, PTAL.

fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/Locker.java

Signed-off-by: shuming.li <[email protected]>

sonarqubecloud · 2024-10-15T13:26:10Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-10-16T02:44:30Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-10-16T02:45:08Z

[FE Incremental Coverage Report]

✅ pass : 6 / 6 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/sql/optimizer/rewrite/scalar/MvNormalizePredicateRule.java	5	5	100.00%	[]
🔵	com/starrocks/common/util/concurrent/lock/Locker.java	1	1	100.00%	[]

github-actions · 2024-10-16T02:46:16Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-10-16T06:48:32Z

@Mergifyio backport branch-3.3

mergify · 2024-10-16T06:48:40Z

backport branch-3.3

✅ Backports have been created

#51965 [BugFix] Fix Attempt to unlock lock, not locked by current locker in mv refresh (backport #51884) has been created for branch branch-3.3 but encountered conflicts

…mv refresh (#51884) Signed-off-by: shuming.li <[email protected]> (cherry picked from commit a1a3130) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/Locker.java # fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTest.java

…mv refresh (backport #51884) (#51965) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>

…mv refresh (backport #51884) (#51965) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]> (cherry picked from commit 5387fe8)

…mv refresh (backport #51884) (backport #51965) (#52043) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

…mv refresh (StarRocks#51884) Signed-off-by: shuming.li <[email protected]>

LiShuMing · 2024-11-05T12:09:40Z

@mergify cherry-pick branch-3.2

mergify · 2024-11-05T12:09:45Z

cherry -pick branch-3.2

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

LiShuMing · 2024-11-05T12:10:01Z

@mergify backport branch-3.2

LiShuMing · 2024-11-05T12:10:07Z

@mergify backport branch-3.1

mergify · 2024-11-05T12:10:08Z

backport branch-3.2

✅ Backports have been created

#52647 [BugFix] Fix Attempt to unlock lock, not locked by current locker in mv refresh (backport #51884) has been created for branch branch-3.2 but encountered conflicts

mergify · 2024-11-05T12:10:12Z

backport branch-3.1

✅ Backports have been created

#52648 [BugFix] Fix Attempt to unlock lock, not locked by current locker in mv refresh (backport #51884) has been created for branch branch-3.1 but encountered conflicts

…mv refresh (#51884) Signed-off-by: shuming.li <[email protected]> (cherry picked from commit a1a3130) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/Locker.java # fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTest.java

…mv refresh (backport #51884) (#52647) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>

…mv refresh (backport #51884) (#52648) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>

…mv refresh (StarRocks#51884) Signed-off-by: shuming.li <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

LiShuMing requested review from a team as code owners October 14, 2024 09:25

mergify bot assigned LiShuMing Oct 14, 2024

github-actions bot added the 3.3 label Oct 14, 2024

starrocks-cr bot reviewed Oct 14, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/sql/analyzer/PlannerMetaLocker.java Outdated Show resolved Hide resolved

starrocks-cr bot reviewed Oct 14, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/Locker.java Outdated Show resolved Hide resolved

LiShuMing requested a review from a team as a code owner October 14, 2024 11:58

satanson previously approved these changes Oct 15, 2024

View reviewed changes

murphyatwork reviewed Oct 15, 2024

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/Locker.java Outdated Show resolved Hide resolved

Fix Attempt to unlock lock, not locked by current locker in mv refresh

0a2d301

Signed-off-by: shuming.li <[email protected]>

LiShuMing dismissed satanson’s stale review via 0a2d301 October 15, 2024 09:27

LiShuMing force-pushed the fix/main/fix_locker_unlock_fail branch from 6c86f61 to 0a2d301 Compare October 15, 2024 09:27

murphyatwork previously approved these changes Oct 15, 2024

View reviewed changes

fix bugs

bc349fe

Signed-off-by: shuming.li <[email protected]>

LiShuMing dismissed murphyatwork’s stale review via bc349fe October 15, 2024 13:18

HangyuanLiu approved these changes Oct 16, 2024

View reviewed changes

kangkaisen approved these changes Oct 16, 2024

View reviewed changes

kangkaisen merged commit a1a3130 into StarRocks:main Oct 16, 2024
48 checks passed

github-actions bot removed the 3.3 label Oct 16, 2024

mergify bot mentioned this pull request Oct 16, 2024

[BugFix] Fix Attempt to unlock lock, not locked by current locker in mv refresh (backport #51884) #51965

Merged

42 tasks

wanpengfei-git pushed a commit that referenced this pull request Oct 17, 2024

[BugFix] Fix Attempt to unlock lock, not locked by current locker in …

5387fe8

…mv refresh (backport #51884) (#51965) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>

github-actions bot added the 3.3-merged label Oct 17, 2024

mergify bot mentioned this pull request Oct 17, 2024

[BugFix] Fix Attempt to unlock lock, not locked by current locker in mv refresh (backport #51884) (backport #51965) #52043

Merged

42 tasks

ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024

[BugFix] Fix Attempt to unlock lock, not locked by current locker in …

24a4a85

…mv refresh (StarRocks#51884) Signed-off-by: shuming.li <[email protected]>

github-actions bot added the 3.3 label Nov 5, 2024

github-actions bot added 3.2 3.1 labels Nov 5, 2024

This was referenced Nov 5, 2024

[BugFix] Fix Attempt to unlock lock, not locked by current locker in mv refresh (backport #51884) #52647

Merged

[BugFix] Fix Attempt to unlock lock, not locked by current locker in mv refresh (backport #51884) #52648

Merged

wanpengfei-git pushed a commit that referenced this pull request Nov 5, 2024

[BugFix] Fix Attempt to unlock lock, not locked by current locker in …

3aba087

…mv refresh (backport #51884) (#52647) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>

github-actions bot added the 3.2-merged label Nov 5, 2024

wanpengfei-git pushed a commit that referenced this pull request Nov 6, 2024

[BugFix] Fix Attempt to unlock lock, not locked by current locker in …

2454d5c

…mv refresh (backport #51884) (#52648) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>

github-actions bot added the 3.1-merged label Nov 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Fix Attempt to unlock lock, not locked by current locker in mv refresh #51884

[BugFix] Fix Attempt to unlock lock, not locked by current locker in mv refresh #51884

LiShuMing commented Oct 14, 2024 •

edited

Loading

murphyatwork Oct 15, 2024

LiShuMing Oct 15, 2024

sonarqubecloud bot commented Oct 15, 2024

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

mergify bot commented Oct 16, 2024 •

edited

Loading

LiShuMing commented Nov 5, 2024

mergify bot commented Nov 5, 2024

LiShuMing commented Nov 5, 2024

LiShuMing commented Nov 5, 2024

mergify bot commented Nov 5, 2024 •

edited

Loading

mergify bot commented Nov 5, 2024 •

edited

Loading

[BugFix] Fix Attempt to unlock lock, not locked by current locker in mv refresh #51884

[BugFix] Fix Attempt to unlock lock, not locked by current locker in mv refresh #51884

Conversation

LiShuMing commented Oct 14, 2024 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

murphyatwork Oct 15, 2024

Choose a reason for hiding this comment

LiShuMing Oct 15, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Oct 15, 2024

Quality Gate passed

github-actions bot commented Oct 16, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Oct 16, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Oct 16, 2024

[BE Incremental Coverage Report]

github-actions bot commented Oct 16, 2024

mergify bot commented Oct 16, 2024 • edited Loading

✅ Backports have been created

LiShuMing commented Nov 5, 2024

mergify bot commented Nov 5, 2024

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

LiShuMing commented Nov 5, 2024

LiShuMing commented Nov 5, 2024

mergify bot commented Nov 5, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Nov 5, 2024 • edited Loading

✅ Backports have been created

LiShuMing commented Oct 14, 2024 •

edited

Loading

mergify bot commented Oct 16, 2024 •

edited

Loading

mergify bot commented Nov 5, 2024 •

edited

Loading

mergify bot commented Nov 5, 2024 •

edited

Loading