[Enhancement] Some enhancements of data file vacuuming for cloud native partition #50342
+958
−184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| @@ -387,4 +398,4 @@ private void waitResponse() { | |||
| } | |||
| } | |||
| } | |||
| } | |||
| } No newline at end of file | |||
There was a problem hiding this comment.
The most risky bug in this code is:
Incorrect condition for removing tablets
You can modify the code like this:
snapshot.tablets.removeIf(t -> ((LakeTablet) t).getDataSizeUpdateTime() < visibleVersionTime &&
((LakeTablet) t).getDataSizeUpdateTime() <= lastSuccVacuumTime);
| @@ -508,7 +547,7 @@ public String toString() { | |||
| buffer.append("versionEpoch: ").append(versionEpoch).append("; "); | |||
| buffer.append("versionTxnType: ").append(versionTxnType).append("; "); | |||
|
|
|||
| buffer.append("storageDataSize: ").append(storageDataSize()).append("; "); | |||
| buffer.append("storageDataSize: ").append(getDataSize()).append("; "); | |||
| buffer.append("storageRowCount: ").append(storageRowCount()).append("; "); | |||
| buffer.append("storageReplicaCount: ").append(storageReplicaCount()).append("; "); | |||
|
|
|||
There was a problem hiding this comment.
The most risky bug in this code is:
Incorrect variable name used in the setLastSuccVacuumTime method.
You can modify the code like this:
@@ -176,13 +177,42 @@ public boolean isImmutable() {
}
@Override
- public long getLastVacuumTime() {
- return lastVacuumTime;
+ public long getLastSuccVacuumTime() {
+ return lastSuccVacuumTime;
}
@Override
- public void setLastVacuumTime(long lastVacuumTime) {
- this.lastVacuumTime = lastVacuumTime;
+ public void setLastSuccVacuumTime(long lastSuccVacuumTime) {
+ this.lastSuccVacuumTime = lastSuccVacuumTime;
+ }
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| public long getMinRetainVersion() { |
There was a problem hiding this comment.
The most risky bug in this code is:
Potential logging null pointer when name is not initialized in the shouldVacuum method.
You can modify the code like this:
if ((storageSize - dataSize >= 50L * 1024 * 1024) && (magnification > 0.1)) {
LOG.debug("Partition: {}, storage size: {}, data size: {}, magnification: {} should vacuum now",
getName(), getStorageSize(), getDataSize(), magnification);
return true;
}
tracymacding
force-pushed
the
add_storage_size_for_cloud_partition
branch
from
39546db to
a8a39ce
Compare
tracymacding
force-pushed
the
add_storage_size_for_cloud_partition
branch
3 times, most recently
from
c3338af to
894eb32
Compare
|
[FE Incremental Coverage Report]✅ pass : 76 / 95 (80.00%) file detail
|
…ve partition
1. Add storage size property for cloud native partition
2. Start vacuum according to partition data size and storage size on S3
3. Add more vacuuming metrics on FE
Signed-off-by: tracymacding <[email protected]>
tracymacding
force-pushed
the
add_storage_size_for_cloud_partition
branch
from
894eb32 to
d40d5c9
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 49 / 61 (80.33%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
To improve data file vacuuming for cloud native table, some enhancements made in this pr:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: