[BugFix] Fix decimal literal equals uncheck type (backport #50626) (#…

…50661) Co-authored-by: Seaven <[email protected]>
StarRocks · Sep 6, 2024 · 7209a49 · 7209a49
1 parent 0a43806
commit 7209a49
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/fe/fe-core/src/main/java/com/starrocks/analysis/DecimalLiteral.java b/fe/fe-core/src/main/java/com/starrocks/analysis/DecimalLiteral.java
@@ -492,4 +492,10 @@ public Expr uncheckedCastTo(Type targetType) throws AnalysisException {
     public int hashCode() {
         return Objects.hash(super.hashCode(), value);
     }
+
+    @Override
+    public boolean equals(Object obj) {
+        return super.equals(obj) && (type.matchesType(((LiteralExpr) obj).getType()));
+    }
+
 }
diff --git a/fe/fe-core/src/test/java/com/starrocks/sql/plan/DecimalTypeTest.java b/fe/fe-core/src/test/java/com/starrocks/sql/plan/DecimalTypeTest.java
@@ -172,4 +172,15 @@ public void testExpressionRangeCheck() throws Exception {
         String plan = getFragmentPlan(sql);
         assertContains(plan, "PREDICATES: 4: c_1_3 <= 1000");
     }
+
+    @Test
+    public void testSameValueDiffTypeDecimal() throws Exception {
+        String sql = "SELECT t1a,\n" +
+                "    sum(t1f * 1.00000000000) / NULLIF(sum(t1c), 0) AS aaaa,\n" +
+                "    sum(t1f * 1.000) / NULLIF(sum(t1d * 1.000), 0) * 1000 AS bbbb\n" +
+                " FROM test_all_type \n" +
+                " GROUP BY t1a;\n ";
+        String plan = getFragmentPlan(sql);
+        assertContains(plan, "<slot 11> : 6: t1f * 1.0\n");
+    }
 }