Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighted Search Suggestions Collapse Spaces in Partial Title #494

Closed
dtimsullivan opened this issue Jul 27, 2022 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@dtimsullivan
Copy link

Describe the Bug

When using the search bar to find a page, the search suggestion highlight seems to remove the space between the highlight span and regular text if the search includes a full word from the title.

Steps to reproduce the behavior:

  1. Go to Search
  2. Type a partial search that includes a full word from an article title.
  3. Notice how the space between the highlighted word and the rest of the title is gone.

I'm able to replicate this on the starcitizen.tools wiki as well.

Expected Behavior

I would expect that the space between the highlighted word and the rest of the title would be maintained.

Temp Fix

I was able to work around this by adding display:block to the .citizen-typeahead-suggestion__title and .citizen-typeahead-suggestion__description classes in CSS.

Before:
Screenshot 2022-07-27 092810
Temp Fix:
Screenshot 2022-07-27 092743
After:
Screenshot 2022-07-27 093255

System

  • MediaWiki version 1.37.1
  • Server OS: Windows Server 2012 R2
  • PHP version 7.4.29
@dtimsullivan dtimsullivan added the bug Something isn't working label Jul 27, 2022
@alistair3149
Copy link
Member

Thanks for the report! I can reproduce the issue and am looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants