Missing newHeight in typscript file

[remijean]

My code :

<AnimateHeight
    duration={500}
    height={childrenHeight}
    onAnimationStart={newHeight => handleAnimationEnd(newHeight)}
>

Typescript return this error :

Type '(newHeight: any) => any' is not assignable to type '() => void'.ts(2322)

I believe that the declaration of newHeight is missing in the onAnimationEnd and onAnimationStart functions :

onAnimationEnd?(): void
onAnimationStart?(): void

to :

onAnimationEnd?(newHeight): void
onAnimationStart?(newHeight): void

[Stanko]

Hello @remijean,
Can you please check all of the type definitions and open a PR? So we can be sure no issues pop up in the future.
Thank you!

[remijean]

Hello @Stanko, I just submitted the pull request ;) .

[Stanko]

Thank you very much! :)

I’m not near the laptop atm, but I will merge and publish it, first thing tomorrow morning.

[Stanko]

Published with 2.0.8 🎉

I made two small changes

Changed children: ReactNode; to children: ReactNode | ReactNode[];
as it can receive multiple children elements.

And changed easing?: "ease" | "linear" | "ease-in" | "ease-out" | "ease-in-out"; to
easing?: "ease" | "linear" | "ease-in" | "ease-out" | "ease-in-out" | string;
to support other timing functions like cubic-bezier and steps.

Cheers!

[remijean]

Thanks you Stanko ! 👍