feat(preview): added service upload

[StanGirard]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented hard-to-understand areas
• I have ideally added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged

Screenshots (if appropriate):

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 18, 2023 0:53am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 18, 2023 0:53am

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/backend/core/main.py

The code seems to be well-structured and follows the SOLID principles. However, there are a few areas that could be improved for better readability and maintainability:

1. Environment Variables: The SENTRY_DSN environment variable is being accessed directly using os.getenv(). It would be better to have a separate configuration file or class to manage all environment variables. This would make the code more maintainable and less prone to errors.

2. Error Handling: The handle_request_validation_error function could be simplified for better readability. Instead of replacing newline and multiple spaces in the exception string, consider using a formatted string or a template string.

Here's an example of how you could refactor the handle_request_validation_error function:

@app.exception_handler(RequestValidationError)
async def validation_exception_handler(request: Request, exc: RequestValidationError):
    exc_str = str(exc).replace('\
', ' ').replace('   ', ' ')
    logger.error(f'Request: {request}, Error: {exc_str}')
    content = {
        'status_code': status.HTTP_422_UNPROCESSABLE_ENTITY,
        'message': exc_str,
        'data': None,
    }
    return JSONResponse(content=content, status_code=status.HTTP_422_UNPROCESSABLE_ENTITY)

3. Startup Event: The startup_event function is downloading pandoc if it doesn't exist. This could potentially slow down the startup time of the application. Consider moving this to a separate script that prepares the environment before the application starts.

---

🌍💼 (Environment Variables), 🚫📝 (Error Handling), 🚀🐌 (Slow Startup)

---

Powered by Code Review GPT