fix(sentry): some unhandled errors

[StanGirard]

Fixed some unhandled errors in sentry

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	Aug 8, 2023 3:15pm
quivrapp	🔄 Building (Inspect)	Visit Preview	Aug 8, 2023 3:15pm

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/backend/core/crawl/crawler.py

1. The exception handling in the _crawl method could be improved. Instead of just printing the exception, it would be better to log it using a logger. This would allow for better tracking of errors and issues.

2. The process method writes the content to a file without checking if the content is None. This could potentially lead to an error. It would be better to check if the content is None before writing it to a file.

Example:

if content:
    with open(temp_file_path, \"w\") as temp_file:
        temp_file.write(content)

---

Risk Level 3 - /home/runner/work/quivr/quivr/backend/core/llm/qa_base.py

1. The generate_answer and generate_stream methods have a lot of duplicated code. This could be refactored into a separate method to improve readability and maintainability.

2. The generate_stream method uses an async for loop to iterate over the callback. It would be better to handle exceptions in this loop to prevent the entire method from failing if an error occurs during iteration.

Example:

async for token in callback.aiter():
    try:
        # process token
    except Exception as e:
        # log exception

---

🐛📝🔄

---

Powered by Code Review GPT