Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add disableTestsConsoleOutput option #27

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

ferrarafer
Copy link
Contributor

Added option on StackedLogger to disable ConsoleOutput during tests.

@ferrarafer ferrarafer changed the title fix: add disable tests console output option fix: add disableTestsConsoleOutput option May 27, 2024
Copy link
Contributor

@FilledStacks FilledStacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready to be merged?

@ferrarafer
Copy link
Contributor Author

@FilledStacks probably 😄 , I will review today or during the weekend and we can merge.

@FilledStacks
Copy link
Contributor

Awesome!

Added kForceConsoleOutput to support override the value on the fly through dart defines.
Copy link
Contributor

@FilledStacks FilledStacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FilledStacks FilledStacks merged commit 76a647f into next Jun 25, 2024
1 check failed
@FilledStacks FilledStacks deleted the fix/add-disable-tests-console-output-option branch June 25, 2024 15:44
FilledStacks pushed a commit that referenced this pull request Jun 25, 2024
# [2.0.0-pre.1](v1.6.1-pre.1...v2.0.0-pre.1) (2024-06-25)

### Bug Fixes

* add disableTestsConsoleOutput option ([#27](#27)) ([76a647f](76a647f))
@FilledStacks
Copy link
Contributor

🎉 This PR is included in version 2.0.0-pre.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants