Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add delete dialog command #34

Merged
merged 12 commits into from
Jul 18, 2023
Merged

feat: add delete dialog command #34

merged 12 commits into from
Jul 18, 2023

Conversation

sebastianbuechler
Copy link
Contributor

@sebastianbuechler sebastianbuechler commented Jun 24, 2023 •
edited
Loading

Tried to add for Stacked-Org/stacked#878

TODO:

  • Delete folder in lib/ui/dialogs/ for respective dialog
  • Unregister dialog in lib/app/app.dart from dialogs parameter
  • Unregister dialog in app/app.dialogs.dart

Tested it locally with a new project, added a dialog, then removed it again. Any other tasks here to do?

Includes minor typo fix for delete_view_command.dart

ferrarafer
ferrarafer requested changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@ferrarafer ferrarafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastianbuechler great PR, thanks for your collaboration. I just made a few requests for changes but overall was very good. Please, try to make the suggested changes and we will merge this PR.

lib/src/commands/delete/delete_dialog_command.dart Show resolved Hide resolved
lib/src/commands/delete/delete_dialog_command.dart Outdated Show resolved Hide resolved
lib/src/commands/delete/delete_dialog_command.dart Outdated Show resolved Hide resolved
lib/src/commands/delete/delete_dialog_command.dart Outdated Show resolved Hide resolved
@ferrarafer ferrarafer changed the title Feature/Add delete dialog command feat: add delete dialog command Jun 26, 2023
@sebastianbuechler
Copy link
Contributor Author

@ferrarafer I also did the adjustment for private functions and parameter addition for the delete commands for service and view so it's consistent.

ferrarafer
ferrarafer requested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@ferrarafer ferrarafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, more changes requested. Thanks for your collaboration, really appreciated.

lib/src/services/pub_service.dart Outdated Show resolved Hide resolved
lib/src/commands/delete/delete_dialog_command.dart Outdated Show resolved Hide resolved
lib/src/commands/delete/delete_dialog_command.dart Show resolved Hide resolved
lib/src/commands/delete/delete_dialog_command.dart Show resolved Hide resolved
lib/src/services/pub_service.dart Outdated Show resolved Hide resolved
ferrarafer
ferrarafer previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@ferrarafer ferrarafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you! There is an issue but not because of your code, is an issue that was already on the code, I'm going to fix it on another branch.

@ferrarafer ferrarafer changed the base branch from main to pre-release July 18, 2023 01:36
@ferrarafer ferrarafer changed the base branch from pre-release to main July 18, 2023 01:37
@ferrarafer ferrarafer dismissed their stale review July 18, 2023 01:37

The base branch was changed.

@ferrarafer ferrarafer changed the base branch from main to pre-release July 18, 2023 01:39
@ferrarafer ferrarafer merged commit 650d8b8 into Stacked-Org:pre-release Jul 18, 2023
FilledStacks pushed a commit that referenced this pull request Jul 18, 2023
@semantic-release-bot
chore(release): 1.11.0 [skip ci]
6f8c3b6 
# [1.11.0](v1.10.0...v1.11.0) (2023-07-18)

### Bug Fixes

* avoid removing multiple dependencies when multiple classes match at the end of the name ([#35](#35)) ([4b0665a](4b0665a))

### Features

* add delete dialog command ([#34](#34)) ([650d8b8](650d8b8))
@FilledStacks
Copy link
Contributor

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sebastianbuechler sebastianbuechler mentioned this pull request Jul 18, 2023
Closed
@ferrarafer ferrarafer mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrarafer ferrarafer ferrarafer left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastianbuechler @FilledStacks @ferrarafer