[BUG] go install instructions do not work

[whi-tw]

The Bug

The installation instructions state that dnscontrol can be installed with go install:

dnscontrol/documentation/getting-started.md

Lines 42 to 44 in 0869052

	```shell
	go install github.com/StackExchange/dnscontrol/v4@latest
	```

However, because of the replace directives, this doesn't actually work:

❯ go version
go version go1.22.5 linux/amd64
❯ go install github.com/StackExchange/dnscontrol/v4@latest
go: github.com/StackExchange/dnscontrol/v4@latest (in github.com/StackExchange/dnscontrol/[email protected]):
        The go.mod file for the module providing named packages contains one or
        more replace directives. It must not contain directives that would cause
        it to be interpreted differently than if it were the main module.

This is not a recently introduced issue: golang/go#44840, so either I'm missing something, or people haven't attempted this in a while!

[cafferata]

The replace directive was introduced in GitHub pull request #3002 here.

replace github.com/cloudflare/cloudflare-go => ./pkg/cloudflare-go

cc: @tlimoncelli

[tlimoncelli]

Oh dang. I had no idea the "replace" directive would have that side-effect. Mea culpa!

We are using a custom version of cloudflare-go to add a particular feature. I do plan on submitting a PR to that project to add that feature so don't need a custom version. However that might take a while.

I propose we add a note that this is currently not working and will be fixed as part of #3056

[whi-tw]

Agreed - updating the docs seems like the best approach for now. I suppose the fact I'm the first person to raise it after two months suggests that this isn't inconveniencing (m)any people too much!

[jauderho]

+1 from me.

I noticed this just the other day when I was trying to use go install too.

It appears to be a long standing issue with Go:

• cmd/go: go install cmd@version errors out when module with main package has replace directive golang/go#44840
• https://www.reddit.com/r/golang/comments/187uok8/the_issue_about_replace_directives_in_the_main/

Looking forward to when the cloudflare-go changes get merged upstream.

[tlimoncelli]

I'm optimistic Cloudflare will accept my PR: cloudflare/cloudflare-go#2833

[cafferata]

You were absolutely right! GitHub pull request cloudflare/cloudflare-go#2833 has been merged! 🚀 👏🏻

[cafferata]

DeleteRulesetRule() has been released in v0.102.0. 🥳

[jauderho]

Confirmed that go install github.com/StackExchange/dnscontrol/v4@e8eca6a compiles just fine.