ConfigurationOptions.ToString does not add brackets to IPv6 address

[mari3728]

Hello!

I'm having an issue when calling ConfigurationOptions.ToString method, when my connection string has an IPv6 address.

Just for some context, I'm using Redis as a backplane for SignalR and I parse my original connection string to enhance it. Then, I convert it back to string to pass it to RedisScaleoutConfiguration ([email protected] - I'm using .Net Framework 4.8).

That's why I need to use ConfigurationOptions.ToString method, and I'd expect my connection string IPv6 address to have brackets added to it.

The following example reproduces the behavior:

 var connectionString = "[::1]:6379,password=mypass";
 var configuration = ConfigurationOptions.Parse(connectionString);
 configuration.AbortOnConnectFail = false;
 configuration.ClientName = "my-client-name";

 var converted = configuration.ToString();
 Console.WriteLine(converted); //expected [::1]:6379, actual: ::1:6379

 var endpoint = configuration.EndPoints.FirstOrDefault().ToString();
 Console.WriteLine(endpoint); //EndPoint.ToString method correctly adds the brackets

From my observation, the ConfigurationOptions.ToString method writes the endpoints using Format class, which directly writes the IP address without checking if that's an IPv6 address.

[mgravell]

Agreed, we need some when love here

[mgravell]

working on it ^^^

[mari3728]

Thanks for the swift fix! Is there an ETA for the next release of StackExchange.Redis package?

[mgravell]

Actually, 2.8.18 is available right now on the myget preview feed (https://www.myget.org/gallery/stackoverflow) - it would be super useful if you're able to try against that build, and check whether it works as you expect (it is the exact same build, as produced by the build-server - just not yet published on NuGet)

[mari3728]

I have installed the version mentioned and it works as expected, thank you!

[mgravell]

Great! There's a few hoops to jump through for a "proper" release (tags, release notes, deploys, etc) - shouldn't be long, but you can happily keep using the myget one for now.