Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup.exe doesn't support version numbers with more than 2 digits #545

Closed
Deozaan opened this issue Jan 6, 2016 · 2 comments
Closed

Setup.exe doesn't support version numbers with more than 2 digits #545

Deozaan opened this issue Jan 6, 2016 · 2 comments

Comments

@Deozaan
Copy link

Deozaan commented Jan 6, 2016

I like to put the date in my version numbers as an easy way to know how old a release is. But that leads to strange behavior in the installer created by Squirrel.

Somehow my version 1.141122.10 is being changed to 1.66.10.0. And if I try to split it up a little by using version 1.14.1122.10 then somehow that becomes 1.14.98.10.

squirrelversionweirdness

Additionally (and this perhaps should be submitted as a separate issue), it seems the "Product Name" is taken from the NuGet Description rather than the NuGet Title.

@anaisbetts
Copy link
Contributor

The Windows PE file format limits all of those fields to a single byte, you have to have a number < 256

@geary
Copy link

geary commented Jan 29, 2016

These version fields are actually unsigned 16-bit values, not 8-bit values. So 1.141122.1 is not a valid version value (the max value for any field is 65535), but 1.14.1122.10 is perfectly valid and should be allowed.

The real issue here is that rcedit is erroneously truncating these values to 8 bits.

I fixed the problem in rcedit, tested it with Squirrel, and put up a PR here.

If you grab the updated version of rcedit it will fix this Squirrel issue.

@ghost ghost mentioned this issue May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants