Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce authentication prompts for EV code signing #1848

Open
nsharma1396 opened this issue Feb 20, 2023 · 1 comment
Open

Reduce authentication prompts for EV code signing #1848

nsharma1396 opened this issue Feb 20, 2023 · 1 comment

Comments

@nsharma1396
Copy link

Squirrel version(s)
Which version(s) of the project are you using?
2.0.1 (via electron-winstaller)

Description
Firstly, this is such an exceptional library! Thanks for all the work on this.

Currently, squirrel.windows iterates through each signable file and invokes signtool.exe on each file one by one. See here
For EV code signing certificates, this pops up authentication on each invocation of signtool which becomes a bit hard to manage. signtool provides us the option to pass multiple file names together as space-separated so a possible improvement here can be that we create a string of space separated file names during this iteration phase and then pass it to the signtool invocation together thus reducing multiple calls to signtool as well as multiple authentication prompts for EV code signing.
Can this be feasible to do here?

@parmdhoot
Copy link

This would really speed up the builds for sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants