Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve progress reporting #1652

Closed
GeertvanHorrik opened this issue Aug 28, 2020 · 2 comments · Fixed by #1656
Closed

Improve progress reporting #1652

GeertvanHorrik opened this issue Aug 28, 2020 · 2 comments · Fixed by #1656

Comments

@GeertvanHorrik
Copy link
Contributor

We have fairly large apps. What we see whenever we run an update:

  1. Instant download (since delta package is normally ~ 2-4 mb)
  2. Squirrel being "stuck" at 66%

Then completing very fast again.

I've been digging into this, and think it's caused by the full packages from delta creation:

var release = await createFullPackagesFromDeltas(updateInfo.ReleasesToApply, updateInfo.CurrentlyInstalledVersion);

I think the apply releases progress can be split into the following:

00 => start
00 => 40 (create full packages from deltas)
40 => 80 (install pacakge to dir)
80 => 85 (update local releases file)
85 => 90 (self update)
90 => 95 (post install)
95 => 96 (remove dead entries)
96 => 97 (unshim ourselves)
96 => 98 (clean dead versions)
100

I think this will more reliably reflect the actually installation status and give users a better sense of progress.

I am happy to implement this (non-breaking) change as a PR if you are open to this.

@anaisbetts
Copy link
Contributor

Seems reasonable, go for it

@GeertvanHorrik
Copy link
Contributor Author

PR is ready for review. Progress is now correctly calculated for both creating packages and installation (in ranges between 0 => 40 and 40 => 80). The rest is still similar to the old situation since I don't think it's worth reporting such fine-grained progress reporting for super fast steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants