Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub crashes if semver segment has leading zero #1286

Closed
cbenard opened this issue Apr 18, 2018 · 3 comments
Closed

Stub crashes if semver segment has leading zero #1286

cbenard opened this issue Apr 18, 2018 · 3 comments

Comments

@cbenard
Copy link
Contributor

cbenard commented Apr 18, 2018

If you use a datestamp version like 2018.0418.1, the YourAppName.exe stub that shortcuts point to will crash on startup, logging the BEX error like people had when they used a 4 part version in #905.

Can this be fixed by updating the semver you depend on?

Ideally, we wouldn't have to use 2018.418.1, because with an ordinal sort, 418 (Apr 18) > 1001 (Oct 1). I'm assuming semver is knowledgeable and does a numeric value compare and not an ordinal sort, but the version is used elsewhere as well.

Thank you.

@cbenard
Copy link
Contributor Author

cbenard commented May 18, 2018

@paulcbetts Hi Paul. I'm not trying to bother you too much, but it's been a month. Have you had a chance to see if a newer semver library can fix this crash?

@anaisbetts
Copy link
Contributor

anaisbetts commented May 18, 2018

This won't be fixed because it is explicitly against the SemVer specification (https://semver.org/):

  1. A normal version number MUST take the form X.Y.Z where X, Y, and Z are non-negative integers, and MUST NOT contain leading zeroes. X is the major version, Y is the minor version, and Z is the patch version. Each element MUST increase numerically. For instance: 1.9.0 -> 1.10.0 -> 1.11.0.

@cbenard
Copy link
Contributor Author

cbenard commented May 18, 2018

Understood. Thanks for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants