applyDiffToFile not checking if the temp file exists before trying to use it

[Pyritie]

DeltaPackage.cs#235.
tempTargetFile is being used but is never checked to see if that file was actually created on disk. In my case, it was not, and so squirrel crashed here.

It had created six folders in SquirrelTemp, tempa through tempf, and it tried to use a tempg that did not exist.

An exception of type 'System.ComponentModel.Win32Exception' occurred in DeltaCompressionDotNet.MsDelta.dll but was not handled in user code

Additional information: The system cannot find the file specified

[Pyritie]

Stack trace:

DeltaCompressionDotNet.MsDelta.dll!DeltaCompressionDotNet.MsDelta.MsDeltaCompression.ApplyDelta(string deltaFilePath, string oldFilePath, string newFilePath)	Unknown
>Squirrel.dll!Squirrel.DeltaPackageBuilder.applyDiffToFile(string deltaPath, string relativeFilePath, string workingDirectory) Line 237	C#
Squirrel.dll!Squirrel.DeltaPackageBuilder.ApplyDeltaPackage.AnonymousMethod__4(string file) Line 120	C#
Squirrel.dll!Squirrel.EnumerableExtensions.ForEach<string>(System.Collections.Generic.IEnumerable<string> source, System.Action<string> onNext) Line 29	C#
Squirrel.dll!Squirrel.DeltaPackageBuilder.ApplyDeltaPackage(Squirrel.ReleasePackage basePackage, Squirrel.ReleasePackage deltaPackage, string outputFile) Line 124	C#
Squirrel.dll!Squirrel.UpdateManager.ApplyReleasesImpl.createFullPackagesFromDeltas.AnonymousMethod__3() Line 331	C#

This happens during await mgr.ApplyReleases(updateInfo).

[gustavocalheiros]

seems related to this one:
#877

[Thieum]

@Pyritie is it an issue you are still experiencing with the latest version of Squirrel?

[Pyritie]

I haven't had this crash in a long time, no, but I know I made some changes to my project and how I do squirrel releases since then. I can't remember what my setup was that caused this crash.

[Thieum]

@shiftkey this can be closed.