Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check failed and I have no clue why #240

Open
mr-newell opened this issue Aug 13, 2019 · 2 comments
Open

Update check failed and I have no clue why #240

mr-newell opened this issue Aug 13, 2019 · 2 comments

Comments

@mr-newell
Copy link

I have a code-signed Electron app to which I'm trying to add auto-update functionality.

I have set up a Lambda function at https://api.staging.my-domain.com/updater/checkUpdates/products/product-name/platforms/darwin?v=1.0.0 which returns a 200-status JSON response that looks like this:

{
  "upgradeStatus": "minor",
  "url": "https://s3.amazonaws.com/my-bucket/staging/installers/latest/My Product Name.zip"
}

I can paste that URL into my browser and it will download the file without a problem.

Despite this, I get the error Error: Update check failed. The server sent an invalid response. Try again later. which is coming from SQRLUpdater.m. Objective-C is looks quite foreign to me though so it's hard to understand what is causing the error to be thrown.

As far as I can tell, I am doing everything I should be to get updates working. Is there something else I need to be doing?

@anaisbetts
Copy link

Escape the spaces in My Product Name, My%20Product%20Name, spaces in URLs aren't actually valid, the browser is fixing it up for you

@mr-newell
Copy link
Author

mr-newell commented Aug 14, 2019

@anaisbetts I was hoping that would fix it but unfortunately it's still failing with the same error even after trying the encoding. I removed the program from Applications and reinstalled it in case the old URL was getting cached somehow but that didn't help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants