Add ability to remove all listeners

call instance.off() with no parameters to remove all listeners at one fell swoop.
SpringRoll · Mar 10, 2015 · 7aa3eb7 · 7aa3eb7
1 parent 0d876b5
commit 7aa3eb7
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 8 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
 	"name": "Bellhop",
-	"version": "1.1.3",
+	"version": "1.1.4",
 	"main": "dist/bellhop.min.js",
 	"dependencies": {
 		"bind-polyfill": "*"

diff --git a/dist/bellhop.js b/dist/bellhop.js
@@ -1,4 +1,4 @@
-/*! Bellhop 1.1.3 */
+/*! Bellhop 1.1.4 */
 (function(window, undefined){
 
 	/**
@@ -332,13 +332,19 @@
 	/**
 	*  Remove an event listener
 	*  @method off
-	*  @param {String} type The type of event to listen for
+	*  @param {String} type The type of event to listen for. If undefined, remove all listeners.
 	*  @param {Function} [callback] The optional handler when an event is triggered, if no callback
 	*         is set then all listeners by type are removed
 	*  @return {Bellhop} Return instance of current object
 	*/
 	p.off = function(type, callback)
 	{
+		if (type === undefined)
+		{
+			//remove all listeners
+			this._listeners = {};
+			return this;
+		}
 		if (this._listeners[type] === undefined)
 		{
 			return this;

diff --git a/dist/bellhop.min.js b/dist/bellhop.min.js
diff --git a/library.json b/library.json
@@ -1,6 +1,6 @@
 {
 	"name": "Bellhop",
-	"version": "1.1.3",
+	"version": "1.1.4",
 	"description": "Javascript event-based communication layer between DOM and iframe.",
 	"url": "https://github.com/CloudKidStudio/Bellhop",
 	"output": "bellhop",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"private": true,
-	"version": "1.1.3",
+	"version": "1.1.4",
 	"dependencies": {
 		"grunt": "~0.4.5",
 		"library-grunt": "*"

diff --git a/src/Bellhop.js b/src/Bellhop.js
@@ -331,13 +331,19 @@
 	/**
 	*  Remove an event listener
 	*  @method off
-	*  @param {String} type The type of event to listen for
+	*  @param {String} type The type of event to listen for. If undefined, remove all listeners.
 	*  @param {Function} [callback] The optional handler when an event is triggered, if no callback
 	*         is set then all listeners by type are removed
 	*  @return {Bellhop} Return instance of current object
 	*/
 	p.off = function(type, callback)
 	{
+		if (type === undefined)
+		{
+			//remove all listeners
+			this._listeners = {};
+			return this;
+		}
 		if (this._listeners[type] === undefined)
 		{
 			return this;