Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace esdoc with esdoc-next #8

Closed
otherguy opened this issue Feb 22, 2021 · 3 comments
Closed

Replace esdoc with esdoc-next #8

otherguy opened this issue Feb 22, 2021 · 3 comments

Comments

@otherguy
Copy link

otherguy commented Feb 22, 2021

Hi! The optional esdoc dependency is outdated and causes security warnings with yarn audit, breaking our CI. Unfortunately yarn add --no-optional is still broken so esdoc gets installed no matter what.

Unfortunately, 0.5.2 was the last version before 1.0.1, and you have specified escoc: ^0.5.2, so that effectively pins it at 0.5.2.

Could you please update esdoc to the latest version? Actually 1.1.0 still pulls in the old, outdates sub-dependencies.

Can esdoc be replaced with esdoc-next?

$ yarn audit
yarn audit v1.22.10
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ high          │ Regular Expression Denial of Service                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ marked                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=0.3.9                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ danger-plugin-code-coverage                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ danger-plugin-code-coverage > esdoc > marked                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://www.npmjs.com/advisories/531                         │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ minimist                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=0.2.1 <1.0.0 || >=1.2.3                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ danger-plugin-code-coverage                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ danger-plugin-code-coverage > esdoc > minimist               │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://www.npmjs.com/advisories/1179                        │
└───────────────┴──────────────────────────────────────────────────────────────┘
2 vulnerabilities found - Packages audited: 1353
Severity: 1 Low | 1 High
✨  Done in 2.37s.
@otherguy otherguy changed the title Update esdoc Update or remove esdoc Feb 22, 2021
@otherguy otherguy changed the title Update or remove esdoc Replace esdoc with esdoc-next Feb 22, 2021
@Spoutnik97
Copy link
Owner

Yes, sure! In fact I can remove it totally 😉

@Spoutnik97
Copy link
Owner

@otherguy I updated it in the version 1.1.6 you can find on NPM

@otherguy
Copy link
Author

Nice, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants