Mixins aren't properly reobfuscated if gradle runs configureReobfTaskFor* task before compileJava #38
Comments
Barteks2x
added a commit
to OpenCubicChunks/CubicWorldGen
that referenced
this issue
Jul 13, 2022
Barteks2x
added a commit
to OpenCubicChunks/CubicChunks
that referenced
this issue
Jul 13, 2022
PepperCode1
added a commit
to Creators-of-Create/Create
that referenced
this issue
Jul 16, 2022
- Refactor JEI category building
- Fix placard item requirement not checking NBT
- Use AddPackFindersEvent instead of ShippedResourcePacks
- Remove unused config values
- Provide separate resource and data formats in pack.mcmeta
- Compress all images
- Update to latest Flywheel
- Disable jarJar inclusion of Flywheel
- Use ${file.jarVersion} instead of ${version}
- Add workaround for SpongePowered/MixinGradle#38
|
Has this been looked into? These workarounds linked above will just add more magic boilerplate to everyone's buildscripts until we forget what it was supposed to fix. |
tterrag1098
added a commit
to Chisel-Team/ConnectedTexturesMod
that referenced
this issue
Oct 28, 2023
Merged
Hantonik
added a commit
to Hantonik/FancyBlockParticles
that referenced
this issue
Feb 18, 2024
Hantonik
added a commit
to Hantonik/FancyBlockParticles
that referenced
this issue
Feb 18, 2024
Hantonik
added a commit
to Hantonik/FancyBlockParticles
that referenced
this issue
Feb 19, 2024
Hantonik
added a commit
to Hantonik/FancyBlockParticles
that referenced
this issue
Feb 19, 2024
octylFractal
added a commit
to octylFractal/MixinGradle
that referenced
this issue
Feb 27, 2024
Without it, it may run ahead of the compile task, where the tsrgFile is missing, and the configuration will not be properly applied Fixes SpongePowered#38
pupnewfster
pushed a commit
to pupnewfster/ConnectedTexturesMod
that referenced
this issue
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As in the title. Gradle is able to shuffle task execution around a bit as long as task dependency constraints are met. I ran into a situation where gradle reordered my tasks such that
configureReobfTaskForShadowJarran beforecompileJavain some cases. This breaks mixin reobf. The solution is to specifymustRunAfter("compileJava")for that those tasksThe text was updated successfully, but these errors were encountered: