Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on ruby 2.6 because of monkey patching make_time #8

Open
codev opened this issue Jan 11, 2022 · 0 comments
Open

Doesn't work on ruby 2.6 because of monkey patching make_time #8

codev opened this issue Jan 11, 2022 · 0 comments

Comments

@codev
Copy link

codev commented Jan 11, 2022

If using ruby 2.6 then

Time.parse('TZID=UTC:19700101T000000')

fails with a stack overflow because date_time_precision monkey patches make_time while calling the original method (aliased as make_time_orig) and make_time calls itself (which now calls the monkey patched version which then calls the make_time_orig again and so on and so on and so on)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant