Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering to wordcloud #361

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

fellnerse
Copy link
Member

Here is what an user wrote us:

Hey it's actually not too late! It's in July, I just like to plan ahead ;)
Hm, from a development perspective I'm not sure on the best way to filter it. I think the text field is a good idea but it might not filter out the fact that some might be 'xxx' and others might be 'xxxxxxx'. Perhaps some kind of regex for repeating characters? I do think this will be a common issue for most analyses, especially for those between romantic partners :)

Kind Regards,

Lauren Spring

Hey Lauren,

thank you for using your website, your feedback and the trust in us!

I’m sorry for that late reply, I guess it’s a bit late now. But maybe for next year? It seems you love your partner really much, considering the amount of ‘xxxxx’ then in the graph :P But seriously, we could add a text field, in which you could add words that should not end up in the word cloud. would that work for you? Or a list of the most X items, where you could remove some of those?

Looking forward hearing from you,

Sebastian,

Hey I love the idea of this and thinking of generating some graphics when me and my partner's anniversary comes around. Little disappointed the word cloud seems to not filter out 'xxxxx' kisses type messages though. That seems to dominate the cloud unfortunately!

Copy link

github-actions bot commented Jun 15, 2024

Visit the preview URL for this PR (updated for commit e441d88):

https://whatsanalyze-80665--pr361-add-filtering-to-wor-380jigrl.web.app

(expires Tue, 02 Jul 2024 08:01:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5796a863d3a1b99df3fcb31feec7a39514d97aa4

Copy link
Member

@PKehnel PKehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not able to test - In the PWA I got an wrong file format error (but same for main)

components/FeedbackBtn.vue Show resolved Hide resolved
components/charts/WordCloud.vue Outdated Show resolved Hide resolved
components/charts/WordCloud.vue Show resolved Hide resolved
@fellnerse
Copy link
Member Author

fellnerse commented Jun 25, 2024

Was not able to test - In the PWA I got an wrong file format error (but same for main)

lets try to fix it for dev then, I'll create a new branch for it, and try to find my old phone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants