This repository has been archived by the owner on Mar 11, 2019. It is now read-only.
Feature/reporter #36
Merged
Feature/reporter #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove reporter supervisor and ReporterChild classes and place aggregating function in MonitorChild class
| * @param device: device targeted. | ||
| * @param tick: tick origin. | ||
| */ | ||
| case class AggPowerReport(topic: String, |
There was a problem hiding this comment.
Why to differentiate PowerReport and AggPowerReport ? Can't we rather use a PowerReport extended with a traitAggregateReport[PowerReport] which provides the details of aggregated values?
huertas
force-pushed
the
feature/reporter
branch
from
ffea2e4 to
ced1807
Compare
Remove the AggPowerChannel, the PowerChannel manage aggregated PowerReport system instead of the AggPowerChannel now
| * Wait to retrieve power reports of all targets from a same monitor to aggregate them | ||
| * into once power report. | ||
| */ | ||
| def aggregate(aggPowerReport: PowerReport, powerReport: PowerReport): Unit = { |
There was a problem hiding this comment.
Why we don't use the abstract type as a type parameter?
AggregatedReport base trait is used to differentiate between simple power report and aggregated power report but always keep the same PowerReport type
use a class (Power.scala) instead of a double to represent power value. You can use this expression for exemple : 1.W to create a power refactor: some other improvements are applied to aggregation system
huertas
force-pushed
the
feature/reporter
branch
from
73c4e7d to
610f304
Compare
add a file reporter add a jfreechart reporter
|
|
||
| def receive: PartialFunction[Any, Unit] = LoggingReceive { | ||
| case MonitorStart(_, id, freq, targs) if muid == id && frequency == freq && targets == targs => start() | ||
| case MonitorStart(_, id, freq, targs, agg) if muid == id && frequency == freq && targets == targs && aggFunction == agg => start() |
There was a problem hiding this comment.
Is it necessary to compare the aggregate functions?
add several string interpolation add toString() function within PowerReport instead of the toString() function in reporters chore(README): update README
| @@ -17,6 +17,8 @@ We all stand on the shoulders of giants and get by with a little help from our f | |||
| * [Akka](http://akka.io) (version 2.3.6 under [Apache 2 license](http://www.apache.org/licenses/LICENSE-2.0)), for asynchronous processing | |||
| * [Typesage Config](https://github.com/typesafehub/config) (version 1.2.1 under [Apache 2 license](http://www.apache.org/licenses/LICENSE-2.0)), for reading configuration files. | |||
| * [Apache log4j2](http://logging.apache.org/log4j/2.x/) (version 2.1 under [Apache 2 license](http://www.apache.org/licenses/LICENSE-2.0)), for logging outside actors. | |||
| * [JFreeChart](http://www.jfree.org/jfreechart/) (version 1.0.19 under [LGPL license](https://www.gnu.org/licenses/lgpl.html)), for creation of interactive and animated charts. | |||
| * [Scala IO](http://jesseeichar.github.io/scala-io-doc/0.4.3/index.html#!/overview) (version 0.4.3), for an extensions of IO | |||
There was a problem hiding this comment.
(version 0.4.3 under [BSD-2-Clause license](http://www.scala-lang.org/license.html))
There was a problem hiding this comment.
Sorry, it's a BSD-3-Clause license
|
close #33 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.