Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support to the PERF_* variables in libmodsecurity #1011

Closed
zimmerle opened this issue Dec 9, 2015 · 2 comments
Closed

Implement support to the PERF_* variables in libmodsecurity #1011

zimmerle opened this issue Dec 9, 2015 · 2 comments

Comments

@zimmerle
Copy link
Contributor

zimmerle commented Dec 9, 2015

The following variables needs to be implemented inside libModSecurity:

  • PERF_ALL
  • PERF_COMBINED
  • PERF_GC
  • PERF_LOGGING
  • PERF_PHASE1
  • PERF_PHASE2
  • PERF_PHASE3
  • PERF_PHASE4
  • PERF_PHASE5
  • PERF_RULES
  • PERF_SREAD
  • PERF_SWRITE

More information about these variables can be found at ModSecurity reference manual: https://github.com/SpiderLabs/ModSecurity/wiki/Reference-Manual

@zimmerle
Copy link
Contributor Author

Instead of using the performance variables which can actually have a negative impact on performance, we would suggest the utilization of Linux instrumentation tools. The utilization of stap, for instance, can lead the same results as the Performance variables plus it allows the user to use the existent tools such as flame-charts to plot the performance information in a easy to read way. There is a stap example in the nginx repository: https://github.com/SpiderLabs/ModSecurity-nginx/blob/master/ngx-modsec.stp

Having said that, I am closing this issue.

@dune73
Copy link
Member

dune73 commented Mar 27, 2018

DURATION can be used to substitute the timings for phase 1 through 5. But the other ones would demand systemtap. DURATION also is buggy and not implemented correctly (if correctness means equal to 2.9.x).

Also the substitution is much more complicated than the native availablity of the perf variables.

I'm going into some length on this problem and the use cases for the performance variables in this ML message: https://sourceforge.net/p/mod-security/mailman/message/36276827/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants