Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confused about the framework integration #3

Open
TheMachineHere opened this issue Sep 12, 2017 · 5 comments
Open

Confused about the framework integration #3

TheMachineHere opened this issue Sep 12, 2017 · 5 comments

Comments

@TheMachineHere
Copy link

TheMachineHere commented Sep 12, 2017

From what i understand, it seems like Live-Tour can only be customized from a json file.

But this means that if i wanted to make a specific change later on that wasn't available in the json props, then i wouldn't be able to customize it.

What i'm asking is that do we always need this line <LiveTour tourURI='hello-world.json' > to be the top line in the render method? I know we can add custom components inside this, but can we change components like pano's which are inside this LiveTour Component?

@matthamil
Copy link

AFAICT @TheMachineHere you are locked into the Live Tour components when using the json file.

@TheMachineHere
Copy link
Author

alright thank you.

@TheMachineHere
Copy link
Author

@matthamil have you ever used this live-tour-lab library? Were you able to make fast responsive scenes with it?

@ctoLarsson
Copy link
Contributor

Hi @TheMachineHere relevant question, let me clarify.

You could use the framework out of the box with no own code, say if a media agency or a property agent wants to make a live tour. In that case you just customize the tour using the json file.

But in you case, where you want to add own code, you have much more flexibility. You simply create your own component and mix those with the existing ones.

For example if you want a Pano component with some custom behaviour you can create a component MachinePano and refer to that one instead in the json file, as you define your tours.

I suggest follow the Hero example in the readme and I think it will be clear. Otherwise please don't hesitate to ask more. Happy to help.

@ctoLarsson
Copy link
Contributor

On your second question about speed:
You can trade-off file size with loading speed, and resolution with device horsepower.

The demo uses a lot of 8192x4096 size files, which are fairly large but necessary for "Full HD" resolution:

  • With 90 degree field of view, you see 1/4 of a 360 picture/video.
  • Hence an 8k photo gives you a 2k view, equivalent to Full HD (1920px wide).

My recommended design guideline:

  • Design for latest devices, iPhone 8, a new Mac or latest Samsung. Then 8k should be no problem.
  • Once done, if old devices are important for your use case, just make a second version of the tour with down-scaled media, and send lower-end devices to that one based on UserAgent.

4k still looks good but not razor sharp, the equivalent of a 1000 pixels wide photo/video.

Just let me know if you have more queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants