Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error on next Reload when partially updating readinglist #14

Closed
SaltatorMortis opened this issue Mar 24, 2019 · 2 comments
Closed

error on next Reload when partially updating readinglist #14

SaltatorMortis opened this issue Mar 24, 2019 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@SaltatorMortis
Copy link

SaltatorMortis commented Mar 24, 2019

everytime when you partially update your chapter of any novel, iE Chapter 15 to Chapter 20 of 30, you will get a error after the next Update until you restart the Extension or your Browser.
before the Update the right Url (/extnu/ url) is displayed in the Pupup.

looks like the building of novel.next fails.

@SaltatorMortis
Copy link
Author

maybe look for this one into the popup.ts
for me its look like a getter gets saved, thus causes the problems after closing the popup (Dead object)

@Spark-NF Spark-NF self-assigned this Apr 3, 2019
@Spark-NF Spark-NF added the bug Something isn't working label Apr 3, 2019
@Spark-NF Spark-NF added this to the 1.2.2 milestone Apr 3, 2019
@Spark-NF
Copy link
Owner

Spark-NF commented Apr 3, 2019

Indeed, I guess when setting the current chapter, some corrupted data from the popup slips into the background data, causing the "dead object" error.

Steps to reproduce:

  1. Open popup
  2. Edit novel chapter to some other chapter (except latest)
  3. Close popup
  4. Wait for auto-refresh or re-open popup and click "Refresh"
  5. Error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants