-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Removing items while dragging causes multiple issues #188
Comments
Here's a codesandbox to play around with: https://codesandbox.io/s/react-sortablejs-forked-oprbs?file=/src/index.js I haven't been able to reproduce all the issues yet, but I've seen a few. |
Update: It turns out that at least some of these issues come from Sortablejs itself: SortableJS/Sortable#1943 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When you are dragging an item, if the
list
prop is updated such that it should remove the element you are dragging we have seen multiple bugs:To Reproduce
Steps to reproduce the behavior:
<ReactSortableJS />
componentlist
prop so that the element you are dragging should be removedExpected behavior
The element you are dragging should be removed with no errors thrown and the state of things continuing to work properly
Information
This is required. Issues without this critical information will be closed.
Versions - Look in your
package.json
for this information:react-sortablejs = 6.0.0 (also had seen this same behavior with an earlier version)
react = 16.9.0
Additional context
Hoping to set up a codesandbox example at some point, just wanted to start the conversation here first
The text was updated successfully, but these errors were encountered: