Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag failure occurs when Swiper is combined with Sortablejs #1960

Closed
yodagg opened this issue Nov 18, 2020 · 2 comments
Closed

Drag failure occurs when Swiper is combined with Sortablejs #1960

yodagg opened this issue Nov 18, 2020 · 2 comments

Comments

@yodagg
Copy link

yodagg commented Nov 18, 2020

Reproduction

https://codesandbox.io/s/interesting-firefly-dim2l?file=/src/index.js

Scenario

If Sortablejs is used in Swiper, it will fail, as shown in the example above.

Steps to Reproduce

Click the button 'Start Swiper'

Describe the bug

Events Swiper and Sortablejs conflict

Version

package version
sortablejs 1.10.2
@yodagg
Copy link
Author

yodagg commented Nov 18, 2020

https://github.com/SortableJS/sortablejs/blob/master/packages/sortable/src/Sortable.ts#L493

Is that ok?

if ( this.options.handle && this.options.stopOnHandle ) {
     evt.stopPropagation()
}

@yodagg
Copy link
Author

yodagg commented Dec 16, 2020

https://swiperjs.com/api/
'noSwiping' can solve this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant