Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio 2015 support #26

Open
dsaltares opened this issue Jan 17, 2016 · 4 comments
Open

Visual Studio 2015 support #26

dsaltares opened this issue Jan 17, 2016 · 4 comments

Comments

@dsaltares
Copy link

  • The renderer doesn't load properly when using the VS2010 project.
  • When using the VS2013 project, you need to upgrade to use the VS2015 compiler.
  • hash_set and hash_map are deprecated (we should be using unordered_set and unordered_map instead.

Do you accept PRs to include a VS2015 solution and use the non deprecated classes?

@abeckus
Copy link
Contributor

abeckus commented Jan 19, 2016

Hi David,
Thanks for pointing out the issue.
I will replace deprecated map/set soon.
Regarding vs2015, I think this will come soon too.

Alan

@dsaltares
Copy link
Author

Thanks for the reply! Do you recommend having a separate local branch with these fixes and wait for your changes or would you prefer me to submit a pull request?

@abeckus
Copy link
Contributor

abeckus commented Jan 20, 2016

Yes, I think it would be better to have local copy for now, and wait for the changes.
Because I don't have any plan to add new features before vs2015 support.
The plan is to remove vs2010 and add vs2015 while keeping vs2013.

Alan

@dsaltares
Copy link
Author

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants